Implement password encryption using an RSA public key #373
Conversation
KarboniteKream
force-pushed
the
feat/rsa-public-key-encryption
branch
from
69c0a22 to
e5be218
Compare
There was a problem hiding this comment.
Thank you very much for this effort! It's appreciated!
Other than the link to mysql I think it will be very hard to follow how auth works here in the driver.
And it looks like you pretty much revisited all auth methods here?
What do you think about adding an additional readme with impl details? So it will be more clear later, and easier to follow in the future.
db-async-common/src/main/java/com/github/jasync/sql/db/Configuration.kt
Outdated
Show resolved
Hide resolved
db-async-common/src/main/java/com/github/jasync/sql/db/Configuration.kt
Outdated
Show resolved
Hide resolved
mysql-async/src/main/java/com/github/jasync/sql/db/mysql/MySQLConnection.kt
Outdated
Show resolved
Hide resolved
db-async-common/src/main/java/com/github/jasync/sql/db/Configuration.kt
Outdated
Show resolved
Hide resolved
Will do! I agree it's difficult to follow, and I was thinking of extracting the authentication logic into a separate class to handle all of this in a later PR (and allow making some optimizations with reading the public key). For now I'll make README explaining how it all works, and later start work on a prototype to hopefully simplify the whole flow. |
KarboniteKream
force-pushed
the
feat/rsa-public-key-encryption
branch
from
f0f1ddf to
a8c7d03
Compare
|
I've addressed the comments. Please take another look. |
| @@ -0,0 +1,60 @@ | |||
| # Authentication methods | |||
|
Let me know if it's ready to merge or anything else you'd like to change before I merge. |
|
It's ready to merge, thanks! |
|
Thanks you for the PR! |
Description
This PR is a follow-up to #358, to implement password encryption over unsafe connection using an RSA public key. This is required for
priority #2as described on this page.Detailed changes
rsaPublicKeyproperty toConfigurationMySQLConnection, and other configuration toHandshakeResponse, so they can be available during authentication phasesSha256PasswordAuthentication