Skip to content

Commit 5b4e521

Browse files
committed
Fix apps endpoint for other Types and message for newer antD version
1 parent fe0935b commit 5b4e521

17 files changed

+86
-75
lines changed

client/packages/lowcoder/src/pages/setting/environments/WorkspaceDetail.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import {
44
Spin,
55
Typography,
66
Tabs,
7-
message,
87
} from "antd";
8+
import { messageInstance } from "lowcoder-design/src/components/GlobalInstances";
99
import {
1010
AppstoreOutlined,
1111
DatabaseOutlined,
@@ -46,9 +46,9 @@ const WorkspaceDetail: React.FC = () => {
4646
try {
4747
const success = await toggleManagedStatus(checked);
4848
if (success) {
49-
message.success(`Workspace is now ${checked ? 'Managed' : 'Unmanaged'}`);
49+
messageInstance.success(`Workspace is now ${checked ? 'Managed' : 'Unmanaged'}`);
5050
} else {
51-
message.error('Failed to change managed status');
51+
messageInstance.error('Failed to change managed status');
5252
}
5353
} finally {
5454
setIsToggling(false);

client/packages/lowcoder/src/pages/setting/environments/components/AppsTab.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { useState, useEffect } from 'react';
2-
import { Card, Button, Divider, Alert, message, Table, Tag, Input, Space, Tooltip, Row, Col } from 'antd';
2+
import { Card, Button, Divider, Alert, Table, Tag, Input, Space, Tooltip, Row, Col } from 'antd';
33
import { SyncOutlined, CloudUploadOutlined, AuditOutlined, AppstoreOutlined, CheckCircleFilled, CloudServerOutlined, DisconnectOutlined, FilterOutlined } from '@ant-design/icons';
44
import Title from 'antd/lib/typography/Title';
55
import { Environment } from '../types/environment.types';
@@ -10,6 +10,7 @@ import { ManagedObjectType, setManagedObject, unsetManagedObject } from '../serv
1010
import { useDeployModal } from '../context/DeployModalContext';
1111
import { appsConfig } from '../config/apps.config';
1212
import history from "@lowcoder-ee/util/history";
13+
import { messageInstance } from 'lowcoder-design/src/components/GlobalInstances';
1314

1415
const { Search } = Input;
1516

@@ -116,10 +117,10 @@ const AppsTab: React.FC<AppsTabProps> = ({ environment, workspaceId }) => {
116117
unmanaged: prev.total - managed
117118
}));
118119

119-
message.success(`${app.name} is now ${checked ? 'Managed' : 'Unmanaged'}`);
120+
messageInstance.success(`${app.name} is now ${checked ? 'Managed' : 'Unmanaged'}`);
120121
return true;
121122
} catch (error) {
122-
message.error(`Failed to change managed status for ${app.name}`);
123+
messageInstance.error(`Failed to change managed status for ${app.name}`);
123124
return false;
124125
} finally {
125126
setRefreshing(false);

client/packages/lowcoder/src/pages/setting/environments/components/DataSourcesTab.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react';
2-
import { Card, Button, Divider, Alert, message, Table, Tag, Input, Space, Tooltip, Row, Col, Avatar } from 'antd';
2+
import { Card, Button, Divider, Alert, Table, Tag, Input, Space, Tooltip, Row, Col, Avatar } from 'antd';
3+
import { messageInstance } from 'lowcoder-design/src/components/GlobalInstances';
34
import {
45
SyncOutlined,
56
CloudUploadOutlined,
@@ -114,10 +115,10 @@ const DataSourcesTab: React.FC<DataSourcesTabProps> = ({ environment, workspaceI
114115
unmanaged: prev.total - managed
115116
}));
116117

117-
message.success(`${dataSource.name} is now ${checked ? 'Managed' : 'Unmanaged'}`);
118+
messageInstance.success(`${dataSource.name} is now ${checked ? 'Managed' : 'Unmanaged'}`);
118119
return true;
119120
} catch (error) {
120-
message.error(`Failed to change managed status for ${dataSource.name}`);
121+
messageInstance.error(`Failed to change managed status for ${dataSource.name}`);
121122
return false;
122123
} finally {
123124
setRefreshing(false);

client/packages/lowcoder/src/pages/setting/environments/components/DeployItemModal.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// components/DeployItemModal.tsx
22
import React, { useState, useEffect } from 'react';
3-
import { Modal, Form, Select, Checkbox, Button, message, Spin, Input, Tag, Space } from 'antd';
3+
import { Modal, Form, Select, Checkbox, Button, Spin, Input, Tag, Space } from 'antd';
4+
import { messageInstance } from 'lowcoder-design/src/components/GlobalInstances';
45
import { Environment } from '../types/environment.types';
56
import { DeployableItemConfig } from '../types/deployable-item.types';
67
import { useEnvironmentContext } from '../context/EnvironmentContext';
@@ -46,7 +47,7 @@ function DeployItemModal({
4647
const targetEnv = environments.find(env => env.environmentId === values.targetEnvId);
4748

4849
if (!targetEnv) {
49-
message.error('Target environment not found');
50+
messageInstance.error('Target environment not found');
5051
return;
5152
}
5253

@@ -58,12 +59,12 @@ function DeployItemModal({
5859
// Execute deployment
5960
await config.deploy.execute(params);
6061

61-
message.success(`Successfully deployed ${item.name} to target environment`);
62+
messageInstance.success(`Successfully deployed ${item.name} to target environment`);
6263
if (onSuccess) onSuccess();
6364
onClose();
6465
} catch (error) {
6566
console.error('Deployment error:', error);
66-
message.error(`Failed to deploy ${config.deploy.singularLabel.toLowerCase()}`);
67+
messageInstance.error(`Failed to deploy ${config.deploy.singularLabel.toLowerCase()}`);
6768
} finally {
6869
setDeploying(false);
6970
}

client/packages/lowcoder/src/pages/setting/environments/components/EditEnvironmentModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { useState, useEffect } from 'react';
2-
import { Modal, Form, Input, Select, Switch, Button, message } from 'antd';
2+
import { Modal, Form, Input, Select, Switch, Button } from 'antd';
33
import { Environment } from '../types/environment.types';
44

55
const { Option } = Select;

client/packages/lowcoder/src/pages/setting/environments/components/QueriesTab.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react';
2-
import { Card, Button, Divider, Alert, message, Table, Tag, Input, Space, Tooltip, Row, Col } from 'antd';
2+
import { Card, Button, Divider, Alert, Table, Tag, Input, Space, Tooltip, Row, Col } from 'antd';
3+
import { messageInstance } from 'lowcoder-design/src/components/GlobalInstances';
34
import {
45
SyncOutlined,
56
CloudUploadOutlined,
@@ -115,10 +116,10 @@ const QueriesTab: React.FC<QueriesTabProps> = ({ environment, workspaceId }) =>
115116
unmanaged: prev.total - managed
116117
}));
117118

118-
message.success(`${query.name} is now ${checked ? 'Managed' : 'Unmanaged'}`);
119+
messageInstance.success(`${query.name} is now ${checked ? 'Managed' : 'Unmanaged'}`);
119120
return true;
120121
} catch (error) {
121-
message.error(`Failed to change managed status for ${query.name}`);
122+
messageInstance.error(`Failed to change managed status for ${query.name}`);
122123
return false;
123124
} finally {
124125
setRefreshing(false);

client/packages/lowcoder/src/pages/setting/environments/components/UserGroupsTab.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { useState, useEffect } from 'react';
2-
import { Card, Button, Alert, message, Table, Tag, Input, Space, Row, Col, Avatar, Tooltip } from 'antd';
2+
import { Card, Button, Alert, Table, Tag, Input, Space, Row, Col, Avatar, Tooltip } from 'antd';
33
import { SyncOutlined, TeamOutlined, UserOutlined, UsergroupAddOutlined, SettingOutlined, CodeOutlined } from '@ant-design/icons';
44
import Title from 'antd/lib/typography/Title';
55
import { Environment } from '../types/environment.types';

client/packages/lowcoder/src/pages/setting/environments/components/WorkspacesTab.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { useState, useEffect } from 'react';
2-
import { Card, Button, Divider, Alert, message, Table, Tag, Input, Space, Tooltip, Row, Col, Avatar } from 'antd';
2+
import { Card, Button, Divider, Alert, Table, Tag, Input, Space, Tooltip, Row, Col, Avatar } from 'antd';
33
import { SyncOutlined, AuditOutlined, TeamOutlined, CheckCircleFilled, CloudServerOutlined, DisconnectOutlined, FilterOutlined } from '@ant-design/icons';
44
import Title from 'antd/lib/typography/Title';
55
import { Environment } from '../types/environment.types';

client/packages/lowcoder/src/pages/setting/environments/context/EnvironmentContext.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import React, {
77
useCallback,
88
ReactNode,
99
} from "react";
10-
import { message } from "antd";
10+
import { messageInstance } from "lowcoder-design/src/components/GlobalInstances";
1111
import { getEnvironments } from "../services/environments.service";
1212
import { Environment } from "../types/environment.types";
1313

@@ -61,10 +61,10 @@ export const EnvironmentProvider: React.FC<ProviderProps> = ({
6161
try {
6262
const data = await getEnvironments();
6363
setEnvironments(data);
64-
} catch (err) {
65-
const errorMessage = err instanceof Error ? err.message : "Failed to load environments list";
66-
setError(errorMessage);
67-
message.error(errorMessage);
64+
} catch (error) {
65+
const errorMessage = error instanceof Error ? error.message : 'Failed to fetch environments';
66+
messageInstance.error(errorMessage);
67+
console.error('Error fetching environments:', error);
6868
} finally {
6969
setIsLoading(false);
7070
}

client/packages/lowcoder/src/pages/setting/environments/context/SingleEnvironmentContext.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import React, {
77
useCallback,
88
ReactNode,
99
} from "react";
10-
import { message } from "antd";
10+
import { messageInstance } from "lowcoder-design/src/components/GlobalInstances";
1111
import { useParams } from "react-router-dom";
1212
import { getEnvironmentById, updateEnvironment } from "../services/environments.service";
1313
import { Environment } from "../types/environment.types";
@@ -100,7 +100,7 @@ import React, {
100100
const updatedEnv = await updateEnvironment(environmentId, data);
101101

102102
// Show success message
103-
message.success("Environment updated successfully");
103+
messageInstance.success("Environment updated successfully");
104104

105105
// Refresh both the single environment and environments list
106106
await Promise.all([
@@ -111,7 +111,7 @@ import React, {
111111
return updatedEnv;
112112
} catch (err) {
113113
const errorMessage = err instanceof Error ? err.message : "Failed to update environment";
114-
message.error(errorMessage);
114+
messageInstance.error(errorMessage);
115115
throw err;
116116
}
117117
}, [environment, environmentId, fetchEnvironment, refreshEnvironments]);

0 commit comments

Comments
 (0)