feat: SPA and index.html serving
#420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoBorai
changed the title
--spa and --index flags
LeoBorai
changed the title
--spa and --index flags--spa and --index flags
LeoBorai
changed the title
--spa and --index flagsindex.html serving
LeoBorai
approved these changes
Feb 27, 2024
IIRC Clap allows you to have dependencies between arguments. I think we can merge this and have that improvement as iteration. |
|
The problem from the description is still there. In the current state |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
If #420 there was still an issue that `--spa would work very weirdly without `--index`; single page applications are never implemented without also using `index.html` files. This PR fixes this by automatically setting `cli.index` to `true` if `cli.spa` is set to true. I could throw an error if the `--index` flag is not passed in with `--spa`, but I think those are way too many keystrokes for a feature someone would already expect I manually tested this and it works great for every case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy/pasted every important bit from the previous PR.
Everything looks great except for one small problem: When the
--spaflag is used, the--indexflag has to be enabled as well. But the code is really split up into a lot of files and I don't know where I can setcli.indextotrueifcli.spaistruein the code