Re-implemented instanceDenylist. #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how the instance denylist is handled by removing the class-level instanceBlacklist, assigning the list directly on the config object, and dropping the pre-filter step for denied instances.
- Eliminated
instanceBlacklistproperty fromHapclass. - Moved denylist assignment from
this.instanceBlacklisttoconfig.instanceBlacklist. - Removed the service-filtering line that applied the denylist.
Comments suppressed due to low confidence (2)
src/hap.ts:339
- Removing the service filter means the denylist is no longer applied—instances in
config.instanceDenylistwill slip through. Re-add a filter usingconfig.instanceBlacklist(or a class property) after loading services to enforce the denylist.
services = services.filter(x => this.types[x.type] !== undefined);
src/hap.ts:124
- [nitpick] Mixing
instanceDenylistandinstanceBlacklistnames can confuse readers. Consider standardizing on one term (e.g., renameconfig.instanceDenylisttoconfig.instanceBlacklistin config schema and docs).
config.instanceBlacklist = config.instanceDenylist || [];
|
For your reference, hap-client has an instance excluding function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-implements instanceDenylist in #27 more efficiently. May be this is originally intended.