Mark and save plugin as disabled if platform fails to initialize #3800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13950433333Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently, if a plugin throws an error when initializing, it takes down the entire Homebridge and forces it into a restart loop.
💡 Proposed solution
If a plugin throws an error when initializing, log an error, mark the plugin as disabled, and update the Homebridge config.
⚙️ Release Notes
The user will have to manually re-enable the plugin when they believe that the issue has been resolved, for example an invalid plugin config.
➕ Additional Information
N/A
Testing
N/A
Reviewer Nudging
N/A