Skip to content

Polish roam example #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 24, 2021
Merged

Polish roam example #65

merged 5 commits into from
Feb 24, 2021

Conversation

crs48
Copy link
Member

@crs48 crs48 commented Feb 24, 2021

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

Merging

For maintainers.

To merge, select "Squash and Merge". Then:

  1. Make sure the top commit message follows Angular Git Commit Guidelines,
  2. Delete all other commit messages in the description, but keep any lines designating co-authors so contributors will retain credit for their contributions.

@crs48 crs48 added the documentation Improvements or additions to documentation label Feb 24, 2021
@crs48 crs48 requested a review from rubinovitz February 24, 2021 20:01
@crs48 crs48 self-assigned this Feb 24, 2021
@vercel
Copy link

vercel bot commented Feb 24, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

homebase-example-counter – ./examples/counter

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-counter/Qdqovqu9JLmHCmDYZKYRukxhCtzp
✅ Preview: https://homebase-example-counter-git-polish-roam-example-homebaseio.vercel.app

homebase-example-todo – ./examples/todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-todo/87AjQJ437Ymaqw8ZePoNV1BrcB35
✅ Preview: https://homebase-example-todo-git-polish-roam-example-homebaseio.vercel.app

homebase-example-ts-firebase-todo – ./examples/typescript-firebase-todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-ts-firebase-todo/4YgD5aEydv8LtrPx9Yvij4UB248t
✅ Preview: https://homebase-examp-git-polish-roam-example-hom-664e7e.vercel.app

homebase-example-roam – ./examples/roam

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-roam/AKJbjtkLM8UEXbzTLEPVd1nAFd8f
✅ Preview: https://homebase-example-roam-git-polish-roam-example-homebaseio.vercel.app

rubinovitz
rubinovitz previously approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crs48 crs48 requested a review from rubinovitz February 24, 2021 21:51
rubinovitz
rubinovitz reviewed Feb 24, 2021
View reviewed changes
examples/roam/src/components/RoamMarkdown.js
code: ({ language, value }) => <CodeBlock language={language}>{value}</CodeBlock>,
code: ({ language, value }) => {
if (value) return <CodeBlock language={language}>{value}</CodeBlock>
return null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

rubinovitz
rubinovitz approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! LGTM!

@crs48 crs48 merged commit 46f4c36 into master Feb 24, 2021
@crs48 crs48 deleted the polish-roam-example branch February 24, 2021 22:11
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

🎉 This PR is included in version 0.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubinovitz rubinovitz rubinovitz approved these changes

Assignees

@crs48 crs48

Labels
documentation Improvements or additions to documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crs48 @rubinovitz