Skip to content

docs(examples): add roam demo #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2021
Merged

docs(examples): add roam demo #62

merged 3 commits into from
Feb 11, 2021

Conversation

crs48
Copy link
Member

@crs48 crs48 commented Feb 10, 2021

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

Merging

For maintainers.

To merge, select "Squash and Merge". Then:

  1. Make sure the top commit message follows Angular Git Commit Guidelines,
  2. Delete all other commit messages in the description, but keep any lines designating co-authors so contributors will retain credit for their contributions.

@crs48 crs48 added the documentation Improvements or additions to documentation label Feb 10, 2021
@crs48 crs48 requested a review from rubinovitz February 10, 2021 17:33
@crs48 crs48 self-assigned this Feb 10, 2021
@vercel
Copy link

vercel bot commented Feb 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

homebase-example-counter – ./examples/counter

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-counter/n2ilce9g4
✅ Preview: https://homebase-example-counter-git-roam.homebaseio.vercel.app

homebase-example-todo – ./examples/todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-todo/1mzgj4qkg
✅ Preview: https://homebase-example-todo-git-roam.homebaseio.vercel.app

homebase-example-ts-firebase-todo – ./examples/typescript-firebase-todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-ts-firebase-todo/er9bcyhmw
✅ Preview: https://homebase-example-ts-firebase-todo-git-roam.homebaseio.vercel.app

homebase-example-roam – ./examples/roam

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-roam/e3w1v24u5
✅ Preview: https://homebase-example-roam-git-roam.homebaseio.vercel.app

Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool! Super excited to get this out there. I added some comments where I thought we could clarify more for developers what's going on. Also commented on some parts where I was impressed by the explanation and simplicity of code.


return (
<div className="my-4">
<Link to={`/page/${block.get('_children', 0, 'uid')}`} className="text-blue-500">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should add a comment about this syntax and what it's doing since I don't think we document it anywhere?

return (
<div className="pl-6">
{children
.filter((b) => b.get('id'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really cool

className="w-full outline-none bg-transparent"
containerClassName="text-base flex"
onChange={(e) => {
// This instantly updates the UI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments here really helpful

transact([['retractEntity', id]])
} else if (e.key === 'Tab' && e.shiftKey) {
e.preventDefault()
const parent = block.get('_children', 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ancestral naming here is really clear/self-explanatory :)

const updatedOrder = (order + nextSiblingOrder) / 2.0
try {
transact([
// Unparent the current block
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love these comments, really clear what's going on

)
}

const renderTextSection = (blockId) => (text, i) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels really clear despite being a bunch of regexes 🥇

Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🚀

@crs48 crs48 merged commit 16c5042 into master Feb 11, 2021
@crs48 crs48 deleted the roam branch February 11, 2021 21:09
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

🎉 This PR is included in version 0.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants