docs(pull_request_template): add merging guidelines #55
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crs48
reviewed
Jan 12, 2021
.github/pull_request_template.md
Outdated
|
|
||
| To merge, select "Squash and Merge". Then: | ||
| 1. Make sure the top commit message follows [Angular Git Commit Guidelines](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines), | ||
| 2. Delete all other commit messages, but keep any lines designating [co-authors](https://docs.github.com/en/free-pro-team@latest/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors) so contributors will retain credit for their contributions. |
There was a problem hiding this comment.
I think we should say something along the lines of this for step 2.
- Clean up the description, make sure to keep any lines designating [co-authors] ...
There was a problem hiding this comment.
@smothers my problem with this is that I don't think it's obvious the commit messages are the "description" when it's filled with commit messages and you can't see the "description" place holder.
Maybe "Delete all other commit messages in the description, but keep any lines designating co-authors so contributors will retain credit for their contributions." ?
There was a problem hiding this comment.
resolved in latest
crs48
previously approved these changes
Jan 12, 2021
crs48
approved these changes
Jan 14, 2021
|
🎉 This PR is included in version 0.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
PR Checklist
Testing
Docs
Typescript