Skip to content

refactor(examples): move examples and their history into this repo #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jan 11, 2021
Merged

refactor(examples): move examples and their history into this repo #46

merged 22 commits into from
Jan 11, 2021

Conversation

rubinovitz
Copy link
Contributor

No description provided.

rubinovitz and others added 17 commits October 29, 2020 14:12
@rubinovitz
Initial commit
53eb9fb
@rubinovitz
add .gitignore
c584f94
@rubinovitz
add counter-example react app
7b2b072
@rubinovitz
add todo-example node_modules to .gitignore
1bb39e5
@rubinovitz
name counter example package.json
2050f88
@rubinovitz
title index.html for counter example
417cc95
@rubinovitz
todo-example
ce707c3
@rubinovitz
Update README.md
9f2470b
@rubinovitz
Update README.md to reflect new repo name
7e1d582
@folz
chore: Code style cleanups
b474241 
Opening this file in my IDE causes it to auto-trim spaces, leading to a busy diff. I also updated `new Date` -> `new Date()` to fix a lint warning on start, and committed the correct package name to package-lock.json.
@rubinovitz
Merge pull request #1 from folz/folz/format
9a1dcc0 
chore: Code style cleanups
@crs48
chore(*): update hbr and cleanup dead code
eae0a39
@crs48
Merge pull request #2 from homebaseio/update-homebase-react
fec947e 
chore(*): update hbr and cleanup dead code
@crs48
perf(todo-example): reduce re-renders (#3)
4e7d1b6 
- take better advantage of homebase-react v0.1.1 attribute tracking
@rubinovitz
feat(typescript-todo): typescript example of todo app (#4)
7180d99
@rubinovitz
Update README.md to add Typescript firebase todo
c9aa79e
@rubinovitz
Merge remote-tracking branch 'homebase-react-examples/main' into merg…
cca694c 
…e-examples
@rubinovitz rubinovitz requested a review from crs48 December 21, 2020 23:21
@rubinovitz rubinovitz self-assigned this Dec 21, 2020
crs48
crs48 reviewed Dec 22, 2020
View reviewed changes
.gitignore Outdated
@@ -25,3 +25,45 @@ pom.xml.asc

.hgignore
.hg/
.DS_STORE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these have to be copied to the root .gitignore? I think it would be easier to maintain if we let each example define its own .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

crs48
crs48 reviewed Dec 22, 2020
View reviewed changes
examples/README.md Outdated
You can clone this repo to have ready to run [homebase-react](https://github.com/homebaseio/homebase-react) examples.

## Examples
[Counter Example](counter-example/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename to counter given these all live in the examples/ folder. And the same goes for all the other examples.

@crs48
Copy link
Member

crs48 commented Dec 22, 2020

Please update the .npmignore to ignore the examples folder. And while you're at it you can also ignore types, src, public and js. I don't see the point of distributing some of the src but not all of it, so if people want the src they'll need to clone the repo.

@crs48
Copy link
Member

crs48 commented Dec 23, 2020

Please update the examples link in the README.md to link here instead of the old examples repo

@rubinovitz
Copy link
Contributor Author

@smothers I believe I addressed all your comments. Can you please re-review tomorrow/Tuesday?

crs48
crs48 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@crs48 crs48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏽

@rubinovitz rubinovitz merged commit b391ab5 into master Jan 11, 2021
@rubinovitz rubinovitz deleted the merge-examples branch January 11, 2021 05:02
@github-actions
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crs48 crs48 crs48 approved these changes

Assignees

@rubinovitz rubinovitz

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubinovitz @crs48 @folz