Skip to content

docs(prs): add pull request template #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 22, 2020
Merged

Conversation

rubinovitz
Copy link
Contributor

How does this look? Trying to make sure we remember any necessary changes while not impeding contribution.

@rubinovitz rubinovitz requested a review from crs48 December 12, 2020 05:34
@rubinovitz rubinovitz added the documentation Improvements or additions to documentation label Dec 12, 2020
@rubinovitz rubinovitz self-assigned this Dec 12, 2020
@rubinovitz
Copy link
Contributor Author

@smothers I think I resolved your issues. Please re-review when you get a chance.

Copy link
Member

@crs48 crs48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubinovitz rubinovitz merged commit 31b4fb8 into master Dec 22, 2020
@rubinovitz rubinovitz deleted the pull-request-template branch December 22, 2020 22:09
@github-actions
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants