HHH-19611 demote many DEBUG-level log messages to TRACE #10520

gavinking · 2025-07-12T18:53:38Z

since Quarkus insists on doing something completely crazy with our INFO level

See https://hibernate.atlassian.net/browse/HHH-19611 for explanation.

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

hibernate-github-bot · 2025-07-12T18:53:43Z

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
↳ Offending commits: [bc0b63e, b02b695, 9c18da9, 2b5299e, 9f6c6d6, fa7dad5, fdcf91d, 0299ac9, 1d31a16, 948bf2d, 9e7e986, e0416b8, 07e8539, 9551111, a23f60d, 25398a4, f372aae, 9f5128d, bd1f595, 99cc7bb, e2ed7b5, d3c7104]

› This message was automatically generated.

hibernate-core/src/main/java/org/hibernate/boot/internal/ClassLoaderAccessImpl.java

hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/MappingBinder.java

-			if ( log.isDebugEnabled() ) {
-				log.debugf( "Performing JAXB binding of hbm.xml document : %s", origin.toString() );
+			if ( log.isTraceEnabled() ) {
+				log.tracef( "Performing JAXB binding of hbm.xml document: %s", origin.toString() );


hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/MappingBinder.java

@@ -181,7 +181,7 @@
 		else {
 			assert "entity-mappings".equals( rootElementLocalName );
 			try {
-				log.debugf( "Performing JAXB binding of orm.xml document : %s", origin.toString() );
+				log.tracef( "Performing JAXB binding of orm.xml document: %s", origin.toString() );


hibernate-core/src/main/java/org/hibernate/cache/spi/support/AbstractReadWriteAccess.java

-			log.debugf( "Getting cached data from region [`%s` (%s)] by key [%s]", getRegion().getName(), getAccessType(), key );
+		final boolean traceEnabled = log.isTraceEnabled();
+		if ( traceEnabled ) {
+			log.tracef( "Getting cached data from region [`%s` (%s)] by key [%s]", getRegion().getName(), getAccessType(), key );


hibernate-core/src/main/java/org/hibernate/cache/spi/support/AbstractReadWriteAccess.java

-				if ( debugEnabled ) {
-					log.debugf( "Cache miss : region = `%s`, key = `%s`", getRegion().getName(), key );
+				if ( traceEnabled ) {
+					log.tracef( "Cache miss : region = `%s`, key = `%s`", getRegion().getName(), key );


hibernate-core/src/main/java/org/hibernate/cache/spi/support/AbstractReadWriteAccess.java

-			if ( log.isDebugEnabled() ) {
-				log.debugf( "Locking cache item [region=`%s` (%s)] : `%s` (timeout=%s, version=%s)", getRegion().getName(), getAccessType(), key, timeout, version );
+			if ( log.isTraceEnabled() ) {
+				log.tracef( "Locking cache item [region=`%s` (%s)] : `%s` (timeout=%s, version=%s)", getRegion().getName(), getAccessType(), key, timeout, version );


hibernate-core/src/main/java/org/hibernate/cache/spi/support/AbstractReadWriteAccess.java

@@ -205,7 +205,7 @@

 	protected void handleLockExpiry(SharedSessionContractImplementor session, Object key, Lockable lock) {
 		L2CACHE_LOGGER.softLockedCacheExpired( getRegion().getName(), key );
-		log.debugf( "Cached entry expired : %s", key );
+		log.tracef( "Cached entry expired: %s", key );


hibernate-core/src/main/java/org/hibernate/cache/spi/support/AbstractReadWriteAccess.java

@@ -219,7 +219,7 @@
 	@Override
 	public void remove(SharedSessionContractImplementor session, Object key) {
 		if ( getStorageAccess().getFromCache( key, session ) instanceof SoftLock ) {
-			log.debugf( "Skipping #remove call in read-write access to maintain SoftLock : %s", key );
+			log.debugf( "Skipping #remove call in read-write access to maintain SoftLock: %s", key );


hibernate-core/src/main/java/org/hibernate/sql/results/internal/ResultsHelper.java

hibernate-core/src/main/java/org/hibernate/internal/SessionImpl.java

@@ -1015,7 +1015,7 @@
 	public Object immediateLoad(String entityName, Object id) {
 		if ( log.isDebugEnabled() ) {
 			final EntityPersister persister = requireEntityPersister( entityName );
-			log.debugf( "Initializing proxy: %s", infoString( persister, id, getFactory() ) );
+			log.tracef( "Initializing proxy: %s", infoString( persister, id, getFactory() ) );


hibernate-core/src/main/java/org/hibernate/loader/ast/internal/AbstractEntityBatchLoader.java

-		if ( MULTI_KEY_LOAD_LOGGER.isDebugEnabled() ) {
-			MULTI_KEY_LOAD_LOGGER.debugf( "Batch fetching entity `%s#%s`", getLoadable().getEntityName(), id );
+		if ( MULTI_KEY_LOAD_LOGGER.isTraceEnabled() ) {
+			MULTI_KEY_LOAD_LOGGER.tracef( "Batch fetching entity `%s#%s`", getLoadable().getEntityName(), id );


hibernate-core/src/main/java/org/hibernate/sql/results/internal/ResultsHelper.java

+			LOG.trace( "Caching collection: "
+					+ collectionInfoString( collectionDescriptor, collectionInstance, key, session ) );


hibernate-core/src/main/java/org/hibernate/cache/spi/support/AbstractReadWriteAccess.java

-				log.debugf( "Caching data from load [region=`%s` (%s)] : key[%s] -> value[%s]", getRegion().getName(), getAccessType(), key, value );
+			final boolean traceEnabled = log.isTraceEnabled();
+			if ( traceEnabled ) {
+				log.tracef( "Caching data from load [region='%s' (%s)] : key[%s] -> value[%s]", getRegion().getName(), getAccessType(), key, value );


since Quarkus insists on doing something completely crazy with our INFO level

put them all in a single log message

because it results in logging telling us not to do it

and clean up some Logger descriptions

…to JdbcLogging and include SF uuid in log messages

…sImpl

at least for now - it was just too verbose

at least for now - it was just too ugly and verbose

hibernate-core/src/main/java/org/hibernate/type/BasicTypeRegistry.java

+				// Incredibly verbose logging disabled
+//				LOG.tracef( "Adding type registration %s -> %s", key, type );
+
+				final Type old = typesByName.put( key, type );


hibernate-core/src/main/java/org/hibernate/type/BasicTypeRegistry.java

+				// Incredibly verbose logging disabled
+//				LOG.tracef( "Adding type registration %s -> %s", key, type );
+
+				final BasicTypeReference<?> old = typeReferencesByName.put( key, type );


motivated by work on logging cleanup

gavinking force-pushed the prefer-trace branch 3 times, most recently from fc1ea5c to 75409ae Compare July 12, 2025 19:13

github-advanced-security bot found potential problems Jul 12, 2025

View reviewed changes

gavinking force-pushed the prefer-trace branch from 75409ae to aed610f Compare July 12, 2025 20:11

github-advanced-security bot found potential problems Jul 12, 2025

View reviewed changes

gavinking force-pushed the prefer-trace branch 2 times, most recently from d5b0f6d to 91a2f1d Compare July 13, 2025 01:02

github-advanced-security bot found potential problems Jul 13, 2025

View reviewed changes

gavinking added 5 commits July 13, 2025 03:42

demote many DEBUG-level log messages to TRACE

bc0b63e

since Quarkus insists on doing something completely crazy with our INFO level

improvements to TRACE-level logging

b02b695

change how HQL functions are logged at startup

9c18da9

put them all in a single log message

avoid use of deprecated service lookup

2b5299e

because it results in logging telling us not to do it

downgrade two more DEBUG-level messages to TRACE

9f6c6d6

gavinking force-pushed the prefer-trace branch from 91a2f1d to 9f6c6d6 Compare July 13, 2025 01:45

gavinking added 14 commits July 13, 2025 08:39

very minor code cleanups in ResourceRegistryStandardImpl

fa7dad5

very minor code cleanups in ManagedTypeProcessor

fdcf91d

introduce ResourceRegistryLogger

0299ac9

and clean up some Logger descriptions

move logging in JdbcCoordinatorImpl and LogicalConnectionManagedImpl …

1d31a16

…to JdbcLogging and include SF uuid in log messages

massive cleanup of NaturalIdResolutionsImpl

948bf2d

move NaturalIdLogging to package with its only client

9e7e986

improve logging for Services and Statistics

e0416b8

trivial changes to logging in JndiServiceImpl

07e8539

move logging to JdbcEnvironmentInitiator to JdbcLogging

9551111

fix verbosity of logging in BootstrapContextImpl and ClassLoaderAcces…

a23f60d

…sImpl

improve log message in StrategySelectorImpl

25398a4

slightly improve format of log message in AttributeFactory

f372aae

more consistent format for logging in boot.model package

9f5128d

remove another ugly log message from query compiler

bd1f595

gavinking added 2 commits July 13, 2025 13:05

disable TRACE logging from type registries

99cc7bb

at least for now - it was just too verbose

disable TRACE logging from SqmFunctionRegistry

e2ed7b5

at least for now - it was just too ugly and verbose

github-advanced-security bot found potential problems Jul 13, 2025

View reviewed changes

gavinking mentioned this pull request Jul 13, 2025

Startup logs to list databases Quarkus connects to quarkusio/quarkus#40922

Open

gavinking changed the title ~~demote many DEBUG-level log messages to TRACE~~ HHH-19611 demote many DEBUG-level log messages to TRACE Jul 13, 2025

Big clean up around natural id stuff

d3c7104

motivated by work on logging cleanup

gavinking mentioned this pull request Jul 13, 2025

HHH-19611 demote many DEBUG-level log messages to TRACE #10525

Merged

gavinking closed this Jul 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HHH-19611 demote many DEBUG-level log messages to TRACE #10520

HHH-19611 demote many DEBUG-level log messages to TRACE #10520

Uh oh!

gavinking commented Jul 12, 2025 •

edited

Loading

Uh oh!

hibernate-github-bot bot commented Jul 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

Check failure

Uh oh!

Check failure

Check failure

Check failure

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check notice

Check notice

Uh oh!

		LOG.trace( "Caching collection: "
		+ collectionInfoString( collectionDescriptor, collectionInstance, key, session ) );

HHH-19611 demote many DEBUG-level log messages to TRACE #10520

HHH-19611 demote many DEBUG-level log messages to TRACE #10520

Uh oh!

Conversation

gavinking commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hibernate-github-bot bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check notice

Check notice

Uh oh!

gavinking commented Jul 12, 2025 •

edited

Loading

hibernate-github-bot bot commented Jul 12, 2025 •

edited

Loading