Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gssapi/mod_auth_gssapi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 75ac8df
Choose a base ref
...
head repository: gssapi/mod_auth_gssapi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 925a9cd
Choose a head ref
  • 14 commits
  • 29 files changed
  • 3 contributors

Commits on Aug 6, 2020

  1. tests: Catch errors during tests setup

    Fixes: #224
    Signed-off-by: Stanislav Levin <slev@altlinux.org>
    stanislavlevin authored and simo5 committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    fcf9d4d View commit details
    Browse the repository at this point in the history
  2. tests: Require python3-devel

    python3-devel is required to build python-gssapi within
    virtualenv.
    
    Signed-off-by: Stanislav Levin <slev@altlinux.org>
    stanislavlevin authored and simo5 committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    70c90bf View commit details
    Browse the repository at this point in the history
  3. tests: Don't override the specific environment by the global one

    This changes the way in which a test environment is prepared.
    
    Before:
    specific -> global
    
    After:
    global -> specific
    
    In particular, this allows setting PATH env variable differed from
    the global configuration.
    
    Fixes: #226
    Signed-off-by: Stanislav Levin <slev@altlinux.org>
    stanislavlevin authored and simo5 committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    731761e View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Emit error in logs if keytab files can't be opened

    This will give a useful warning to admins when config point to missing
    files.
    
    Signed-off-by: Simo Sorce <simo@redhat.com>
    simo5 authored and frozencemetery committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8ef0dc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Add warnings if s4u2proxy options are inconsistent

    In most cases, people configuring GssapiUseS4U2Proxy should really
    set all three cred store options for keytab, client_keytab, and ccache
    to isolate httpd from default system ccaches and keytabs.
    
    Not doing so unintentionally easily leads to very hard to debug issues
    when trying to use the proxying feature.
    
    Not enforcing as a hard misconfiguration both for compatibility reasons
    and also because there are corner cases where the configuration is
    intentional.
    
    Signed-off-by: Simo Sorce <simo@redhat.com>
    [rharwood@redhat.com: typo fix and commit message cleanup]
    Reviewed-by: Robbie Harwood <rharwood@redhat.com>
    simo5 authored and frozencemetery committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    b4b43c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Move to python3 by default

    When moving 2 -> 3, python elected to keep "python" as the name of the
    python2 interpreter.  As a result, python3-only machines have no
    /usr/bin/python.  Since python2 is EOL, it should be safe to make our
    scripting default to python3.
    
    Signed-off-by: Robbie Harwood <rharwood@redhat.com>
    frozencemetery authored and simo5 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    1a08c31 View commit details
    Browse the repository at this point in the history
  2. Fix PATH handling bug in test suite

    virtualenv relies on its executable being ahead of the system ones.  For
    setting up the KDC, we don't have a preferencee - we just need the sbins
    to be available.
    
    Signed-off-by: Robbie Harwood <rharwood@redhat.com>
    frozencemetery authored and simo5 committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    45fa4f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Fix type/token distinction in parser.y

    Bison complains that, for yacc compliance, %type is for nonterminals.
    
    Resolves: #236
    Signed-off-by: Robbie Harwood <rharwood@redhat.com>
    frozencemetery authored and simo5 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    27ad217 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Add test that exercises S4u2Proxy code

    This test shows that currently GssapiAcceptor {HOSTNAME} option will
    break the S4U2Proxy case.
    
    Signed-off-by: Simo Sorce <simo@redhat.com>
    [rharwood@redhat.com: nits]
    simo5 committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    7339786 View commit details
    Browse the repository at this point in the history
  2. Special ccache handling for {HOSTNAME} acceptor

    This applies only to the case when GssapiS4U2Proxy is enabled.
    
    When using the {HOSTNAME} acceptor, the principal used in the server
    ccache can vary with each request. GSSAPI does not handle gracefully
    a request to resolve a ccache if there is already another credential
    under a different name. Even with ccache collections GSSAPI will
    resolve an existing ccache from the collection if any is available and
    throw an error if it does not match the desired_name. This even if
    there is a client_keytab that could be used to initiate a new cache in
    the collection with the right name.
    
    Therefore in case GssapiAcceptor is set to the special value {HOSTNAME},
    instead of using the provided ccache or the process default ccache we
    create a new ccache named after the hostname in the delegated ccache
    directory. This directory is required when the S4U2Proxy mode is enabled
    so we are guaranteed to have it available an writable.
    
    Signed-off-by: Simo Sorce <simo@redhat.com>
    [rharwood@redhat.com: nits]
    simo5 committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    a84b9a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. CI: install openssl on Fedora

    Signed-off-by: Robbie Harwood <rharwood@redhat.com>
    frozencemetery authored and simo5 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    43d1031 View commit details
    Browse the repository at this point in the history
  2. crypto: Handle EVP changes in OpenSSL 3

    OpenSSL 3 changes the padding behavior of EVP_DecryptFinal_ex(), which
    causes our decryption to fail.  It is the opnion of the OpenSSL
    developers that mod_auth_gssapi's use of this function was incorrect.
    
    Patch suggested by Tomáš Mráz.
    
    Related: openssl/openssl#16351
    
    Signed-off-by: Robbie Harwood <rharwood@redhat.com>
    frozencemetery authored and simo5 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    06d1f7d View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Update authors file

    Signed-off-by: Simo Sorce <simo@redhat.com>
    simo5 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    78f1d04 View commit details
    Browse the repository at this point in the history
  2. Release version 1.6.4

    Signed-off-by: Simo Sorce <simo@redhat.com>
    simo5 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    925a9cd View commit details
    Browse the repository at this point in the history
Loading