Skip to content

xds: Envoy proto sync to #12224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

shivaspeaks
Copy link
Member

@shivaspeaks shivaspeaks commented Jul 16, 2025

envoyproxy/envoy: Sync protos to the latest imported version envoyproxy/envoy@1128a52 (commit 2025-06-18).

Should be a noop, just a routine xDS proto update.

@shivaspeaks shivaspeaks requested a review from ejona86 July 16, 2025 16:24
@shivaspeaks
Copy link
Member Author

Note: I added cidr.proto that's in xds and address.proto myself. import.sh didn't add it and then it was failing for files not found.

@ejona86
Copy link
Member

ejona86 commented Jul 16, 2025

Note: I added cidr.proto that's in xds and address.proto myself. import.sh didn't add it and then it was failing for files not found.

import.sh has a list of files to import.

@shivaspeaks
Copy link
Member Author

shivaspeaks commented Jul 16, 2025

Oh we have a different import.sh for xds protos.
https://github.com/grpc/grpc-java/blob/master/xds/third_party/xds/import.sh#L20

So we need to update import new version from xds OSS in a same way? Is there any rulebook or some process to follow? Maybe we should be doing both imports in separate PRs.

@ejona86
Copy link
Member

ejona86 commented Jul 16, 2025

It wouldn't be weird to upgrade the "xds" and "envoy" protos at the same time. You might need to upgrade even more than that at once to get everything working together.

@shivaspeaks
Copy link
Member Author

Oh I didn't see your comment here, and I was already working and created a PR for xds proto import: #12225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants