add method to parse field definition from Parser #4006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 318 files 318 suites 2m 32s ⏱️ Results for commit c4c1b51. |
bbakerman
reviewed
Jun 9, 2025
| 'foo(a:String!,b:Int!): Foo' | _ | ||
| 'foo(a:String! ="defaultValue",b:Int!): Foo' | _ | ||
| 'foo(a:String!,b:Int!): Foo @directive(someValue:String)' | _ | ||
| } |
There was a problem hiding this comment.
What about the failure case - what happens when it fails to parse? Will it throw and exception and if so lets lock that in with a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.