Skip to content

DataLoader dispatching for Subscriptions #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2025
Merged

Conversation

andimarek
Copy link
Member

@andimarek andimarek commented May 24, 2025

This adds the normal per level data batching to subscriptions events.

Before the dispatching would alway happen directly after a dataloader was used, meaning there was not batching happening.

Copy link
Contributor

github-actions bot commented May 24, 2025

Test Results

  318 files    318 suites   2m 29s ⏱️
4 686 tests 4 677 ✅ 9 💤 0 ❌
4 775 runs  4 766 ✅ 9 💤 0 ❌

Results for commit cbd4505.

♻️ This comment has been updated with latest results.

Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went thought the commits that make it pass - nice

@andimarek andimarek merged commit 4dc7965 into master Jun 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants