Add ArchUnit rule to ban javax & JetBrains nullability annotations #3985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondonz
commented
May 23, 2025
| @@ -176,7 +176,7 @@ shadowJar { | |||
| bnd(''' | |||
| -exportcontents: graphql.* | |||
| -removeheaders: Private-Package | |||
| Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!javax.annotation.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.jspecify.annotations;resolution:=optional,* | |||
| Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.jspecify.annotations;resolution:=optional,* | |||
There was a problem hiding this comment.
While I'm here, we can clean up our config to remove javax.annotation
Test Results 317 files 317 suites 2m 28s ⏱️ Results for commit 08c8bd3. |
|
We also need to add this to gradle itself, right? Or am I missing something here? |
This runs as a standard test. If there's a violation, it'll turn up in our usual build as a failing test Or did you mean about adding ArchUnit as a dependency? It was already added in another PR that added a rule |
andimarek
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going forward we will be using JSpecify Nullability annotations.
It's possible to accidentally pull in the old javax Nullability annotations because this doesn't need any changes to our build.gradle dependencies.
While it's unlikely someone would accidentally add JetBrains Nullability annotations, because these require a new dependency to be added, I have also banned them.
Sample test output when a banned usage is found: