make dataloader work inside defer blocks #3980

andimarek · 2025-05-22T02:44:41Z

No description provided.

github-actions · 2025-05-22T08:45:11Z

Test Results

316 files ± 0 316 suites ±0 2m 26s ⏱️ ±0s
4 656 tests +1 002 4 647 ✅ +998 9 💤 +4 0 ❌ ±0
4 745 runs +1 002 4 736 ✅ +998 9 💤 +4 0 ❌ ±0

Results for commit a7cc794. ± Comparison against base commit 9ac3e63.

This pull request removes 192 and adds 1172 tests. Note that renamed tests count towards both.

	?
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
                a2 :  __type(name : "t1") { name }
…

graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@6f3f0fae delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@63fdffcd delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@7428de63 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@655523dd delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@6f7e336b delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@3a2b2322 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@60e21209 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@35835fa delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@4dafba3e delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@15bc339 delegate=graphql.AssertTest@7a2e0858 owner=graphql.AssertTest@7a2e0858 thisObject=graphql.AssertTest@7a2e0858 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
…

This pull request skips 4 tests.

graphql.GraphqlErrorHelperTest ‑ can handle custom extensions and custom error classification
graphql.GraphqlErrorHelperTest ‑ can handle custom extensions with classification
graphql.GraphqlErrorHelperTest ‑ can parse out a map and make an error
graphql.GraphqlErrorHelperTest ‑ can turn error classifications into extensions

♻️ This comment has been updated with latest results.

src/test/groovy/graphql/execution/instrumentation/dataloader/DeferWithDataLoaderTest.groovy

src/test/groovy/graphql/execution/incremental/IncrementalCallStateDeferTest.groovy

src/main/java/graphql/execution/incremental/DeferredCallContext.java

src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java

src/main/java/graphql/execution/incremental/DeferredExecutionSupport.java

felipe-gdr · 2025-05-25T22:17:42Z

...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java

-         * The expected field fetch count is accurate when all execute object calls happened
-         * The expected execute object count is accurate when all sub selections fetched
-         * are done in the previous level
+         * A general overview of teh tracked data:


typo: "the"

...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java

src/test/groovy/graphql/execution/instrumentation/dataloader/BatchCompareDataFetchers.java

make dataloader work inside defer blocks

15f6952

andimarek mentioned this pull request May 22, 2025

makes the level notion more clear #3981

Closed

andimarek added 9 commits May 22, 2025 22:21

green tests

da6886a

update gradle wrapper validation

018248a

update gradle wrapper validation

9aaa118

Merge branch 'master' into defer-dataloader

e7e4c36

cleanup

386ce8f

more complex test

fcf7261

cleanup

17911d3

cleanup and docs

5c64ad4

cleanup

c8f4362

felipe-gdr reviewed May 23, 2025

View reviewed changes

src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java Outdated Show resolved Hide resolved

andimarek added 4 commits May 23, 2025 11:30

testing

e0181e3

cleanup

f345f14

cleanup

c12be77

cleanup

aa206d7

dondonz added this to the 25.x breaking changes milestone May 23, 2025

andimarek mentioned this pull request May 23, 2025

Defer dataloader with profiler #3986

Closed