Skip to content

Avoid rare TCK test failure #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Avoid rare TCK test failure #3975

merged 1 commit into from
May 16, 2025
+2 −1

Conversation

andimarek
Copy link
Member

use always a new thread for the tck verification as the TCK uses thread locals to track things, which can cause tests failure in rare cases

@andimarek
use always a new thread for the tck verification as the TCK uses thre…
dcb9b05 
…ad locals to track things, which can cause tests failure in rare cases
@andimarek andimarek requested a review from bbakerman May 16, 2025 03:36
@github-actions GitHub Actions
Copy link
Contributor

Test Results

  315 files  ±0    315 suites  ±0   2m 27s ⏱️ +2s
3 647 tests ±0  3 642 ✅ ±0  5 💤 ±0  0 ❌ ±0 
3 736 runs  ±0  3 731 ✅ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit dcb9b05. ± Comparison against base commit c16cf96.

This pull request removes 150 and adds 128 tests. Note that renamed tests count towards both. 
	?
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
                a2 :  __type(name : "t1") { name }
…

graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@525eac20>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@51e722fc>
graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@79e72fac>
graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@24c67fda>
graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@51476b96>
graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@60d22fce>
graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@d763063 fieldCollector=graphql.execution.FieldCollector@4debf7c4 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@34b3fc15 dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@75096f5c resolvedType=graphql.execution.ResolveType@49c0bcb6>, #0]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@707f2bbc fieldCollector=graphql.execution.FieldCollector@4e32c960 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@25bf91c dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@60028d15 resolvedType=graphql.execution.ResolveType@69296862>, #1]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@406570d2 fieldCollector=graphql.execution.FieldCollector@6e58b55 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@60881be8 dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@31b78ac5 resolvedType=graphql.execution.ResolveType@5a3f9fc1>, #0]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@61cd05ab fieldCollector=graphql.execution.FieldCollector@233d6218 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@2c560bf1 dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@2192ffe8 resolvedType=graphql.execution.ResolveType@287b562c>, #1]
…

@andimarek andimarek added the not release related changes which are not released (for example unit tests or docs) label May 16, 2025
@andimarek andimarek merged commit 444af98 into master May 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees
No one assigned
Labels
not release related changes which are not released (for example unit tests or docs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andimarek @bbakerman