upgrade gradle to 8.9 #3672
Merged
upgrade gradle to 8.9 #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andimarek
added
the
not release related
dondonz
reviewed
Jul 28, 2024
| @@ -1,6 +1,6 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip | |||
There was a problem hiding this comment.
Double checking: Were there no other changes (such as .gradlew) when you updated?
There was a problem hiding this comment.
yeah seems wrong - doesnt it download the internet and check it in?
There was a problem hiding this comment.
the only thing that needs to be updated maybe too is the gradle wrapper itself, but it is not strictly needed always. But we should still try to do it at the same time, and I missed it, this time: see #3675
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.