Skip to content

Bug Fix: Logging During Authorization #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

kevin-carroll
Copy link
Member

  • Fixed a bug where if a ClaimsPrincipal was set by a piece of middleware in the seucrity pipleine, the default authentication middleware would inadvertently log a blank warning message since it didn't perform the authentication itself. The middleware now only logs messages if it attempts the authentication itself

  • Fixed a bug where if a authorization challenge result was set by a piece of middleware in the security pipeline, the default authorization middleware would inadvertently log the challenge result , even when it did not determine this result itself. This could result double logging in some use scenarios. The default authorization component will now only log a challenge result it if produces the result itself.

@kevin-carroll kevin-carroll merged commit f536888 into master Oct 8, 2023
@kevin-carroll kevin-carroll deleted the feature/securityMessaging branch October 8, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants