Skip to content

updated the highlights.js plugin #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2019
Merged

updated the highlights.js plugin #5856

merged 2 commits into from
Nov 7, 2019

Conversation

maschinensehen
Copy link
Contributor

This is my request for a new feature.

I just ran into the issue that we want to put SAS code files (some analytics software suite https://www.sas.com/) into our gogs but that there was no working synthax hightlighting for these file types. I figured out that you are using highlights.js as a plugin for this and further figured out that the current version of highlights.js actually supports SAS.

I therefore herewith suggest to update the plugin to the current version.

While locally testing my changes I noticed that the automatic language deduction for SAS files did not always work and therefore I added some additional code that explicitly sets the language type for highlights.js based on the file exentsion of the source file.

I think that this is a nice to have for everyone, and thus the pull request.

@unknwon
Copy link
Member

unknwon commented Nov 7, 2019

Nice, thank you!

@unknwon unknwon merged commit 7d9f408 into gogs:master Nov 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants