fix: OnInflatedObjectContent doesn't include object contents #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bored-engineer thanks for opening this PR. We are trying to limit changes to the existing v5, please propose this against the It would make sense to have this an opt-in - due to the performance implications. To do this safely we will have to return a copy of the underlying array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #799 packfile.Parser was refactored to reduce memory usage and no longer properly invokes the packfile.Observer interface. Specifically,
OnInflatedObjectContentis invoked butcontentwill always benil.This PR restores the
contentbytes for callers that are directly using packfile.Parser outside of the more standard workflow where the values are stored in a storer.