fix: support empty pushes #1249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
requested changes
Dec 18, 2024
Comment on lines
+165
to
+167
| if bytes.Equal(b, pktline.Flush) { | ||
| return ErrFlushPacketRecieved | ||
| } |
There was a problem hiding this comment.
This would also represent an empty update-request message, and due to that I am thinking we are better off reusing the existing ErrEmpty.
| } | ||
|
|
||
| d := &updReqDecoder{r: rc, s: pktline.NewScanner(r)} | ||
| d := &updReqDecoder{r: io.NopCloser(r), s: pktline.NewScanner(r)} |
There was a problem hiding this comment.
This is trickier, as in the existing behaviour the callee is responsible for closing the reader r, with this change this swifts to the caller. For breaking changes such as this, the commit/PR would have to target v6-exp instead.
There was a problem hiding this comment.
I think this can be revert, right? So the fix for up-to-date git client could be fixed.
|
As for test: simple operation of |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1014 by returning a new
ErrFlushPacketRecievederror when an emptyrecieve-packrequest is sent by an up-to-date git client. This error can then be gracefully handled in upstream code as required.I've also included a fix to the reader closing errors reported in #234, but this might be over eager, because the original code appears to have been deliberately structured to only use the
io.NopCloserutility in a specific case?I can split up the commit into the respective fixes with the ticket numbers if required. Looking forward to any and all feedback.