fix(push): we need to allow pushing to a remote by name and refspec #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for pushing to a remote by its name and branch name.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the push command to allow specifying a remote by name (instead of URL) and pushing specific local branches by name without requiring full refspec syntax.
- Added logic to load repository config and detect a remote by its configured name
- Updated refspec handling: branch names are converted into forced
+local:refs/heads/remoterefspecs - Imported new packages (
fmt,plumbing) to support the above changes
Comments suppressed due to low confidence (2)
cmd/gogit/push.go:71
- This unconditionally generates a forced (
+) refspec torefs/heads/..., overriding any user-supplied refspec syntax and force-pushing by default. Consider retaining originalconfig.RefSpec(arg)ifargalready appears to be a valid refspec pattern, or make forced vs. regular push optional.
str := fmt.Sprintf("+%s:refs/heads/%s", ref.String(), ref.Short())
cmd/gogit/push.go:71
- [nitpick] The variable name
stris too generic. Consider renaming it torefspecorspecfor clarity.
str := fmt.Sprintf("+%s:refs/heads/%s", ref.String(), ref.Short())
Comment on lines
+50
to
+52
| for remote := range cfg.Remotes { | ||
| if args[0] == remote { | ||
| remoteName = remote |
There was a problem hiding this comment.
Iterating for remote := range cfg.Remotes yields integer indices, not remote names, so comparing args[0] == remote will not compile. Use for _, remote := range cfg.Remotes and compare args[0] == remote.Name.
Suggested change
| for remote := range cfg.Remotes { | |
| if args[0] == remote { | |
| remoteName = remote | |
| for _, remote := range cfg.Remotes { | |
| if args[0] == remote.Name { | |
| remoteName = remote.Name |
Copilot uses AI. Check for mistakes.
pjbgf
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for pushing to a remote by its name and branch name.