fix: ensure all functions return a promise

clayreimann · clayreimann · commit 0e3d37b9931b · 2016-05-11T10:39:43.000-05:00
Closes github-tools#326
diff --git a/lib/Issue.js b/lib/Issue.js
@@ -30,7 +30,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    createIssue(issueData, cb) {
-      this._request('POST', `/repos/${this.__repository}/issues`, issueData, cb);
+      return this._request('POST', `/repos/${this.__repository}/issues`, issueData, cb);
    }
 
    /**
@@ -41,7 +41,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    listIssues(options, cb) {
-      this._requestAllPages(`/repos/${this.__repository}/issues`, options, cb);
+      return this._requestAllPages(`/repos/${this.__repository}/issues`, options, cb);
    }
 
    /**
@@ -52,7 +52,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    listIssueComments(issue, cb) {
-      this._request('GET', `/repos/${this.__repository}/issues/${issue}/comments`, null, cb); // jscs:ignore
+      return this._request('GET', `/repos/${this.__repository}/issues/${issue}/comments`, null, cb); // jscs:ignore
    }
 
    /**
@@ -63,7 +63,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    getIssueComment(id, cb) {
-      this._request('GET', `/repos/${this.__repository}/issues/comments/${id}`, null, cb); // jscs:ignore
+      return this._request('GET', `/repos/${this.__repository}/issues/comments/${id}`, null, cb); // jscs:ignore
    }
 
    /**
@@ -75,7 +75,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    createIssueComment(issue, comment, cb) {
-      this._request('POST', `/repos/${this.__repository}/issues/${issue}/comments`, {body: comment}, cb); // jscs:ignore
+      return this._request('POST', `/repos/${this.__repository}/issues/${issue}/comments`, {body: comment}, cb); // jscs:ignore
    }
 
    /**
@@ -87,7 +87,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    editIssueComment(id, comment, cb) {
-      this._request('PATCH', `/repos/${this.__repository}/issues/comments/${id}`, {body: comment}, cb); // jscs:ignore
+      return this._request('PATCH', `/repos/${this.__repository}/issues/comments/${id}`, {body: comment}, cb); // jscs:ignore
    }
 
    /**
@@ -98,7 +98,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    deleteIssueComment(id, cb) {
-      this._request('DELETE', `/repos/${this.__repository}/issues/comments/${id}`, null, cb); // jscs:ignore
+      return this._request('DELETE', `/repos/${this.__repository}/issues/comments/${id}`, null, cb); // jscs:ignore
    }
 
    /**
@@ -110,7 +110,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    editIssue(issue, issueData, cb) {
-      this._request('PATCH', `/repos/${this.__repository}/issues/${issue}`, issueData, cb);
+      return this._request('PATCH', `/repos/${this.__repository}/issues/${issue}`, issueData, cb);
    }
 
    /**
@@ -121,7 +121,7 @@ class Issue extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    getIssue(issue, cb) {
-      this._request('GET', `/repos/${this.__repository}/issues/${issue}`, null, cb);
+      return this._request('GET', `/repos/${this.__repository}/issues/${issue}`, null, cb);
    }
 }
 
diff --git a/lib/Organization.js b/lib/Organization.js
@@ -30,7 +30,7 @@ class Organization extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    createRepo(options, cb) {
-      this._request('POST', `/orgs/${this.__name}/repos`, options, cb);
+      return this._request('POST', `/orgs/${this.__name}/repos`, options, cb);
    }
 
    /**
diff --git a/lib/Repository.js b/lib/Repository.js
@@ -530,7 +530,7 @@ class Repository extends Requestable {
          return cb(null, this.__currentTree.sha);
       }
 
-      this.getRef(`heads/${branch}`, function(err, sha) {
+      return this.getRef(`heads/${branch}`, function(err, sha) {
          this.__currentTree.branch = branch;
          this.__currentTree.sha = sha;
          cb(err, sha);

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class Organization extends Requestable {`
`30`	`30`	`* @return {Promise} - the promise for the http request`
`31`	`31`	`*/`
`32`	`32`	`createRepo(options, cb) {`
`33`		- this._request('POST', `/orgs/${this.__name}/repos`, options, cb);
	`33`	+ return this._request('POST', `/orgs/${this.__name}/repos`, options, cb);
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,7 @@ class Repository extends Requestable {`
`530`	`530`	`return cb(null, this.__currentTree.sha);`
`531`	`531`	`}`
`532`	`532`
`533`		- this.getRef(`heads/${branch}`, function(err, sha) {
	`533`	+ return this.getRef(`heads/${branch}`, function(err, sha) {
`534`	`534`	`this.__currentTree.branch = branch;`
`535`	`535`	`this.__currentTree.sha = sha;`
`536`	`536`	`cb(err, sha);`