Don't require Arc in router
#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still support Arc
gorzell
reviewed
Aug 21, 2024
| @@ -38,12 +38,29 @@ impl prost_build::ServiceGenerator for ServiceGenerator { | |||
| } | |||
| writeln!(buf, "}}").unwrap(); | |||
|
|
|||
| writeln!(buf, "#[twirp::async_trait::async_trait]").unwrap(); | |||
| writeln!(buf, "impl<T> {service_name} for std::sync::Arc<T>").unwrap(); | |||
There was a problem hiding this comment.
I think that you could actually impl for AsRef<T> rather than Arc<T> and cover more cases. Arc has a blanket impl for AsRef I believe.
|
This PR was included in v0.8.0, released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the signature of
routerto generalize to requiringCloneinstead of forcing wrapping inArc. This enables services to implement their own inner ownership logic.This is a breaking change.