Don't require Client to be wrapped in Arc
#71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneubeck
reviewed
Jul 26, 2024
| http_client, | ||
| middlewares, | ||
| inner: Arc::new(ClientRef { |
There was a problem hiding this comment.
It looks like the only variable part is the host field...
Therefore, it makes sense IMO to move the http_client also into the ClientRef struct so that all the immutable parts are shared with just one Arc.
There was a problem hiding this comment.
Since http_client is a reqwest::Client it's already internally managing another Arc so I don't know if it makes sense to add one more layer of Arcs.
aneubeck
approved these changes
Jul 26, 2024
|
This PR was included in v0.8.0, released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like the
twirp::Clientto behave a little closer to the underlyreqwest::Clientwhich doesn't require a wrappingArcto reuse.There is one tricky requirement here that we have over in blackbird - and that is that we dynamically set the hostname per request in one primary use case of this library. I'd previously implemented that as per-request middleware, but that was a bit tricky to get working with the inner
Arcapproach so I've opted for a less generic version of the same functionality.Breaking change, so I've bumped the version.