Skip to content

Make fields on Timings private, expose total elapsed #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

tclem
Copy link
Member

@tclem tclem commented Jul 22, 2024

This is a breaking change, but we had one service that was trying to log/stat the Instant values (which isn't very helpful) so I'm proposing to change this so that we only expose durations.

@tclem tclem requested a review from a team as a code owner July 22, 2024 16:36
Copy link
Contributor

@jorendorff jorendorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh. I thought I had fixed the code logging these fields. Certainly they should not be logged.

Concern: Don't forget the version bump.

@tclem tclem added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 6550406 Jul 23, 2024
2 checks passed
@tclem tclem deleted the tclem/timing-duration branch July 23, 2024 21:44
@CleanCut
Copy link
Contributor

This PR was included in v0.8.0, released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants