Add a generic client error #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorendorff
reviewed
Jul 22, 2024
crates/twirp/src/client.rs
Outdated
|
|
||
| /// A generic error that can be used by custom middleware. | ||
| #[error(transparent)] | ||
| Generic(#[from] GenericError), |
There was a problem hiding this comment.
Yeah, that seems good.
Suggestion: The variant could be called MiddlewareError.
Concern: This requires a crate version bump because it's a breaking change.
If you'd like the freedom to add more error variants in the future, add #[non_exhaustive] to the enum. But note that this is itself a breaking change.
There was a problem hiding this comment.
Good idea. Renamed. And I added #[non_exhaustive] since this is already a breaking change.
Concern: This requires a crate version bump because it's a breaking change.
We don't actually have a formal release yet (though we should do this), but I agree about the version bump.
jorendorff
approved these changes
Jul 22, 2024
|
This PR was included in v0.8.0, released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
I wanted to sketch out a way to allow middleware to return custom errors. What do people think about this approach? @jorendorff?
If we like this, I can add a test and maybe an example usage.