Upgrade install tools strategy #104
Merged
+5
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the tool installation strategy by removing manual file operations and version checking logic, delegating these responsibilities to dedicated scripts included in the distribution package.
- Removes complex version checking and marker file management logic
- Replaces manual file movement operations with calls to dedicated scripts
- Simplifies the overall refresh process by using
repair.shandinstall-tools.shfrom the distribution
| echo "$RELEASE_ID" | sudo tee "$RELEASE_MARKER_FILE" > /dev/null | ||
|
|
||
| echo "Tools installed successfully." | ||
| bash spark-sdk-dist/repair.sh |
There was a problem hiding this comment.
No error handling for the repair.sh script execution. If this script fails, the installation process will continue silently, potentially leading to an inconsistent state.
Suggested change
| bash spark-sdk-dist/repair.sh | |
| bash spark-sdk-dist/repair.sh | |
| if [ $? -ne 0 ]; then | |
| echo "Error: repair.sh script failed. Aborting installation." >&2 | |
| exit 1 | |
| fi |
Copilot uses AI. Check for mistakes.
.devcontainer/refreshTools.sh
Outdated
|
|
||
| echo "Tools installed successfully." | ||
| bash spark-sdk-dist/repair.sh | ||
| LATEST_RELEASE="$LATEST_RELEASE" DIST_DIR="$DIST_DIR" WORKSPACE_DIR=$WORKSPACE_DIR bash spark-sdk-dist/install-tools.sh |
There was a problem hiding this comment.
No error handling for the install-tools.sh script execution. If this script fails, the user won't receive clear feedback about the failure.
Suggested change
| LATEST_RELEASE="$LATEST_RELEASE" DIST_DIR="$DIST_DIR" WORKSPACE_DIR=$WORKSPACE_DIR bash spark-sdk-dist/install-tools.sh | |
| LATEST_RELEASE="$LATEST_RELEASE" DIST_DIR="$DIST_DIR" WORKSPACE_DIR=$WORKSPACE_DIR bash spark-sdk-dist/install-tools.sh | |
| if [ $? -ne 0 ]; then | |
| echo "Error: install-tools.sh script failed to execute successfully." | |
| echo "Please check the logs above for more details." | |
| rm -rf $TEMP_DIR | |
| exit 1 | |
| fi |
Copilot uses AI. Check for mistakes.
alexagillman
approved these changes
Jul 15, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.