Switch on the type of git reference and set its target accordingly

joshvera · joshvera · commit ed68f7ac3b62 · 2015-06-30T14:10:31.000-04:00
diff --git a/LibGit2Sharp/ReferenceCollection.cs b/LibGit2Sharp/ReferenceCollection.cs
@@ -250,9 +250,25 @@ public virtual Reference UpdateTarget(Reference symbolicRef, Reference targetRef
             }
 
             using (ReferenceSafeHandle referencePtr = RetrieveReferencePtr(symbolicRef.CanonicalName))
-            using (ReferenceSafeHandle handle = Proxy.git_reference_symbolic_set_target(referencePtr, targetRef.CanonicalName, signature, logMessage))
             {
-                return Reference.BuildFromPtr<Reference>(handle, repo);
+                GitReferenceType type = Proxy.git_reference_type(referencePtr);
+
+                DirectReference directRef = targetRef.ResolveToDirectReference();
+
+                if (type == GitReferenceType.Symbolic)
+                {
+                    using (ReferenceSafeHandle handle = Proxy.git_reference_symbolic_set_target(referencePtr, directRef.TargetIdentifier, signature, logMessage))
+                    {
+                        return Reference.BuildFromPtr<Reference>(handle, repo);
+                    }
+                }
+                else
+                {
+                    using (ReferenceSafeHandle handle = Proxy.git_reference_set_target(referencePtr, directRef.Target.Id, signature, logMessage))
+                    {
+                        return Reference.BuildFromPtr<Reference>(handle, repo);
+                    }
+                }
             }
         }
 
