fix CanRewriteSymbolicRefsPointingToTags

joshvera · joshvera · commit 9c42473d57c8 · 2015-07-02T22:46:08.000-04:00
diff --git a/LibGit2Sharp/ReferenceCollection.cs b/LibGit2Sharp/ReferenceCollection.cs
@@ -253,17 +253,17 @@ public virtual Reference UpdateTarget(Reference symbolicRef, Reference targetRef
             {
                 GitReferenceType type = Proxy.git_reference_type(referencePtr);
 
-                DirectReference directRef = targetRef.ResolveToDirectReference();
 
                 if (type == GitReferenceType.Symbolic)
                 {
-                    using (ReferenceSafeHandle handle = Proxy.git_reference_symbolic_set_target(referencePtr, directRef.TargetIdentifier, signature, logMessage))
+                    using (ReferenceSafeHandle handle = Proxy.git_reference_symbolic_set_target(referencePtr, targetRef.CanonicalName, signature, logMessage))
                     {
                         return Reference.BuildFromPtr<Reference>(handle, repo);
                     }
                 }
                 else
                 {
+                    DirectReference directRef = targetRef.ResolveToDirectReference();
                     using (ReferenceSafeHandle handle = Proxy.git_reference_set_target(referencePtr, directRef.Target.Id, signature, logMessage))
                     {
                         return Reference.BuildFromPtr<Reference>(handle, repo);

Original file line number	Diff line number	Diff line change
`@@ -253,17 +253,17 @@ public virtual Reference UpdateTarget(Reference symbolicRef, Reference targetRef`
`253`	`253`	`{`
`254`	`254`	`GitReferenceType type = Proxy.git_reference_type(referencePtr);`
`255`	`255`
`256`		`- DirectReference directRef = targetRef.ResolveToDirectReference();`
`257`	`256`
`258`	`257`	`if (type == GitReferenceType.Symbolic)`
`259`	`258`	`{`
`260`		`- using (ReferenceSafeHandle handle = Proxy.git_reference_symbolic_set_target(referencePtr, directRef.TargetIdentifier, signature, logMessage))`
	`259`	`+ using (ReferenceSafeHandle handle = Proxy.git_reference_symbolic_set_target(referencePtr, targetRef.CanonicalName, signature, logMessage))`
`261`	`260`	`{`
`262`	`261`	`return Reference.BuildFromPtr<Reference>(handle, repo);`
`263`	`262`	`}`
`264`	`263`	`}`
`265`	`264`	`else`
`266`	`265`	`{`
	`266`	`+ DirectReference directRef = targetRef.ResolveToDirectReference();`
`267`	`267`	`using (ReferenceSafeHandle handle = Proxy.git_reference_set_target(referencePtr, directRef.Target.Id, signature, logMessage))`
`268`	`268`	`{`
`269`	`269`	`return Reference.BuildFromPtr<Reference>(handle, repo);`