bugfix - do not resolve remote nick if it contains "/"

shiftkey · shiftkey · commit 5e68be41e76e · 2015-07-20T12:56:28.000+09:30
A user can set their upstream during a push by using the full URL
and adding --set-upstream. This adds a config value and bypasses all
the existing remote lookup checks in libgit2. This means an error
occurs when trying to resolve the URL to a remote nick.

We should return a null remote here. This might also be necessary to
fix in libgit2, but for now i'm just yoloing things.
diff --git a/LibGit2Sharp/Branch.cs b/LibGit2Sharp/Branch.cs
@@ -177,6 +177,16 @@ public virtual Remote Remote
                     return null;
                 }
 
+                // upstream git uses the "/" character to denote
+                // when a nick should not be resolved to a remote
+                // TODO:
+                // there's probably some pushspec stuff still to
+                // address here, but let me make this bugfix first
+                if (remoteName.Contains("/"))
+                {
+                    return null;
+                }
+
                 return repo.Network.Remotes[remoteName];
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,16 @@ public virtual Remote Remote`
`177`	`177`	`return null;`
`178`	`178`	`}`
`179`	`179`
	`180`	`+ // upstream git uses the "/" character to denote`
	`181`	`+ // when a nick should not be resolved to a remote`
	`182`	`+ // TODO:`
	`183`	`+ // there's probably some pushspec stuff still to`
	`184`	`+ // address here, but let me make this bugfix first`
	`185`	`+ if (remoteName.Contains("/"))`
	`186`	`+ {`
	`187`	`+ return null;`
	`188`	`+ }`
	`189`	`+`
`180`	`190`	`return repo.Network.Remotes[remoteName];`
`181`	`191`	`}`
`182`	`192`	`}`