Tommy/expand-list-discussions-tool #690
Open
+327
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the list_discussions tool by adding ordering capabilities and expanding the discussion payload to include author information and updated timestamps. The changes enable users to sort discussions by creation or update date in ascending or descending order, while maintaining backward compatibility with existing functionality.
- Added
updatedAtandauthor.loginfields to the discussion payload - Implemented ordering support with
orderByanddirectionparameters - Refactored GraphQL query handling to support optional parameters through pre-defined query variants
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| pkg/github/discussions.go | Added new query struct types, ordering logic, and GraphQL query selection based on parameters |
| pkg/github/discussions_test.go | Updated test data and added comprehensive test cases for ordering functionality |
| README.md | Updated documentation to reflect new ordering parameters |
…ommaso-moro/github-mcp-server into tommy/expand-discussions-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #670
Overview
This PR expands the functionality of the
list_discussionstool. It addsupdatedAtandauthor.login(i.e. username) fields to the discussions payload in thelist_discussionstoolupdated_atandcreated_at) and direction (ascending order, descending order)Refactoring
The PR includes extensive refactoring of the
list_discussionstool to handle optional parameters in our graphql queries. This was needed because the githubv4 library requires GraphQL queries to be defined using Go struct tags that must be known at compile time, so we could not dynamically construct query strings at runtime based on user input.The changes made include
DiscussionFragmentstruct to avoid field duplicationBasicNoOrder: No optional parameters (uses GitHub API's defaults)BasicWithOrder: Only ordering parametersWithCategoryNoOrder: Only category filteringWithCategoryAndOrder: Both category and orderingTests
I updated the tests in
discussions_test.goto match the new queries, and to test the new ordering functionality with different sorting combinations.Demo
Simple "list discussions" prompt
Ordering: from most recently created to least recently created
Ordering: from least recently updated to most recently updated
Less explicit prompt: show me discussions from last 10 days
Ordering with weaker model (GPT-4o)
Note: this PR adds author data to the payload of the
list_discussionstool but doesn't add support for filtering by author when listing discussions because that is not supported on the discussions field in the API, and it would need to be achieved in a separate search tool.