Skip to content

Merge dev-v2 branch into master #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Oct 16, 2014
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
ee14d5b
Add classic, recursive membership validators
mtodd Sep 24, 2014
72a543a
GitHub::Ldap is a class
mtodd Sep 24, 2014
c2dcbba
Fix doco for MembershipValidators module
mtodd Sep 24, 2014
f412a05
Missed Base
mtodd Sep 24, 2014
4017f92
Significant fixes and :nail_care:
mtodd Sep 24, 2014
4dbf604
Add rudimentary tests for MembershipValidators
mtodd Sep 24, 2014
00e8a03
Doco base methods
mtodd Sep 24, 2014
8d87584
CNs are hardcoded elsewhere
mtodd Sep 24, 2014
65dbcb9
Accept String DN for member_filter
mtodd Sep 24, 2014
97ba49b
Use member_filter for Recursive group search
mtodd Sep 24, 2014
90fb34a
Remove FIXME
mtodd Sep 24, 2014
a1d9d79
Extract attributes
mtodd Sep 24, 2014
7f8bf86
Fix subgroup fixture CNs
mtodd Sep 26, 2014
8bb1586
Add recursion tests for classic, recursive strategies
mtodd Sep 26, 2014
e97af8d
Autoload MembershipValidators::Base too
mtodd Sep 26, 2014
26d6bfd
Tweak docs
mtodd Sep 26, 2014
3efbdc1
Document attrs, make internal method private
mtodd Sep 26, 2014
0b98dc5
Refer to full class name in docs
mtodd Sep 26, 2014
76cefb8
Give these blocks some breathing room
mtodd Sep 26, 2014
d31baf5
Accept UID String for posix_member_filter
mtodd Sep 26, 2014
45bf499
Handle posixGroup memberships
mtodd Sep 26, 2014
5d7d6f4
Add deep nested posixGroup membership fixtures
mtodd Sep 26, 2014
084cdf2
Add tests for recursive posixGroup membership validation
mtodd Sep 26, 2014
58a5315
Hook up separate OpenLDAP install, build steps
mtodd Sep 27, 2014
7ae8fec
Merge pull request #45 from github/membership-validators
mtodd Sep 27, 2014
8759205
RVM exec rake for testing ApacheDS tests
mtodd Sep 27, 2014
392410f
Simplify a bit
mtodd Sep 27, 2014
5844fe6
Fast finish, simplify script, remove extraneous bits
mtodd Sep 29, 2014
2397389
Compute relative path to cd into, add debugging output
mtodd Sep 29, 2014
efcd72e
Bundle exec
mtodd Sep 29, 2014
f566aba
bundle install
mtodd Sep 29, 2014
4efafa6
Install, configure, seed OpenLDAP
mtodd Sep 30, 2014
6058337
:fire: unnecessary debugging
mtodd Sep 30, 2014
af39c0c
Fail on error, adjust base path computation
mtodd Sep 30, 2014
6e2d2c3
Wipe out old config first
mtodd Sep 30, 2014
e4f0a19
Switch things around to keep the path sane
mtodd Sep 30, 2014
2e4ce0f
Run the test suite with OpenLDAP
mtodd Sep 30, 2014
19d2fb9
Go back to dc=github,dc=com to match existing fixtures
mtodd Sep 30, 2014
2c6e174
Start test server with ladle when in apacheds test env only
mtodd Sep 30, 2014
33ad5a8
I hear commas are good
mtodd Sep 30, 2014
94d5b82
Create a 'common' fixture file
mtodd Oct 6, 2014
d2065f7
Hardcode server options
mtodd Oct 6, 2014
1e2b52e
Remove test-specific fixtures, use common seed
mtodd Oct 6, 2014
f0a3d75
Remove quiet option when verbose is set
mtodd Oct 6, 2014
19aa507
Use ENV.fetch with default
mtodd Oct 6, 2014
d80dbc5
Update one Domain test with correct fixture
mtodd Oct 6, 2014
010fbc4
Fix Domain posixGroup tests, fixtures
mtodd Oct 6, 2014
b3ac5f3
Add byebug as an development, test bundler dependency
mtodd Oct 6, 2014
1fe748e
Experiment with reusing the ApacheDS LDAP server for each test
mtodd Oct 6, 2014
34d63f6
byebug is supported on MRI 2.0, 2.1 only
mtodd Oct 6, 2014
84e37ce
Add supporting fixtures, fix email domain
mtodd Oct 6, 2014
919734e
Use common seed for OpenLDAP
mtodd Oct 6, 2014
46fea0d
Rewrite Domain tests
mtodd Oct 6, 2014
a1988ab
Include gidNumber in seed; fix posixGroup schema
mtodd Oct 6, 2014
102351c
Rewrite GitHub::Ldap tests
mtodd Oct 6, 2014
6502ab1
Fix Group tests, add fixture group with missing members
mtodd Oct 7, 2014
15953cc
Fix up posixGroup tests
mtodd Oct 8, 2014
db13ebd
Merge pull request #48 from github/cibuild-openldap
mtodd Oct 8, 2014
7014299
Update membership validator tests
mtodd Oct 8, 2014
108d290
Include general membership validator test cases
mtodd Oct 8, 2014
e14a910
Merge pull request #49 from github/fix-membership-validator-tests
mtodd Oct 8, 2014
655f231
add failing test
Oct 15, 2014
e132db4
pass through search options
Oct 15, 2014
3f02551
Merge pull request #51 from github/limit-attributes
jch Oct 15, 2014
5ec9b36
:fire: unneeded LDIF fixtures
mtodd Oct 15, 2014
9d154e8
Require membership validator strategies
mtodd Oct 15, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🔥 unneeded LDIF fixtures
  • Loading branch information
mtodd committed Oct 15, 2014
commit 5ec9b3699d68f10fa1710a8607d543a45daaaa05
82 changes: 0 additions & 82 deletions test/fixtures/github-with-looped-subgroups.ldif

This file was deleted.

85 changes: 0 additions & 85 deletions test/fixtures/github-with-missing-entries.ldif

This file was deleted.

105 changes: 0 additions & 105 deletions test/fixtures/github-with-posixGroups.ldif

This file was deleted.

Loading