Downcase group classes to match Net::LDAP behavior

mtodd · mtodd · commit d29f991689a8 · 2014-08-27T18:45:46.000-07:00
diff --git a/lib/github/ldap/group.rb b/lib/github/ldap/group.rb
@@ -72,9 +72,12 @@ def member_names
       # Internal - Check if an object class includes the member names
       # Use `&` rathen than `include?` because both are arrays.
       #
+      # NOTE: object classes are downcased by default in Net::LDAP, so this
+      # will fail to match correctly unless we also downcase our group classes.
+      #
       # Returns true if the object class includes one of the group class names.
       def group?(object_class)
-        !(GROUP_CLASS_NAMES & object_class).empty?
+        !(GROUP_CLASS_NAMES.map(&:downcase) & object_class.map(&:downcase)).empty?
       end
 
       # Internal - Generate a hash with all the group DNs for caching purposes.
