Ensure payload is distinct from what's passed in

mtodd · mtodd · commit b3ecf39e458b · 2014-08-30T23:22:29.000-07:00
This is because we modify what comes in (with, at the very least,
:result).
diff --git a/lib/github/ldap/instrumentation.rb b/lib/github/ldap/instrumentation.rb
@@ -13,6 +13,7 @@ module Instrumentation
       #
       # Returns the return value of the block.
       def instrument(event, payload = {})
+        payload = (payload || {}).dup
         if instrumentation_service
           instrumentation_service.instrument(event, payload) do |payload|
             payload[:result] = yield(payload) if block_given?

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ module Instrumentation`
`13`	`13`	`#`
`14`	`14`	`# Returns the return value of the block.`
`15`	`15`	`def instrument(event, payload = {})`
	`16`	`+ payload = (payload \|\| {}).dup`
`16`	`17`	`if instrumentation_service`
`17`	`18`	`instrumentation_service.instrument(event, payload) do \|payload\|`
`18`	`19`	`payload[:result] = yield(payload) if block_given?`