Doc, reorder variables to make purpose explicit

mtodd · mtodd · commit 909da53b87a6 · 2015-01-15T13:37:50.000-08:00
diff --git a/lib/github/ldap/member_search/recursive.rb b/lib/github/ldap/member_search/recursive.rb
@@ -34,9 +34,11 @@ def initialize(ldap, options = {})
         #
         # Returns Array of Net::LDAP::Entry objects.
         def perform(group)
-          found    = Hash.new
+          # track groups found
+          found = Hash.new
+
+          # track DNs searched for (so we don't repeat searches)
           searched = []
-          entries  = []
 
           # if this is a posixGroup, return members immediately (no nesting)
           uids = member_uids(group)
@@ -89,6 +91,9 @@ def perform(group)
             end
           end
 
+          # entries to return
+          entries  = []
+
           # pull member DNs, discarding dupes and subgroup DNs
           member_dns = found.values.each_with_object([]) do |group, member_dns|
             entries << group
