fix tls_options on nil input

jonabc · jonabc · commit 272c61d02f14 · 2017-06-06T11:13:44.000-07:00
diff --git a/lib/github/ldap.rb b/lib/github/ldap.rb
@@ -245,6 +245,7 @@ def capabilities
     def check_encryption(encryption, tls_options = {})
       return unless encryption
 
+      tls_options ||= {}
       case encryption.downcase.to_sym
       when :ssl, :simple_tls
         { method: :simple_tls, tls_options: tls_options }
diff --git a/test/ldap_test.rb b/test/ldap_test.rb
@@ -45,6 +45,8 @@ def test_tls_validation
                  @ldap.check_encryption(:tls, verify_mode: OpenSSL::SSL::VERIFY_NONE))
     assert_equal({ method: :start_tls, tls_options: { cert_store: "some/path" } },
                  @ldap.check_encryption(:tls, cert_store: "some/path"))
+    assert_equal({ method: :start_tls, tls_options: {} },
+                 @ldap.check_encryption(:tls, nil))
   end
 
   def test_search_delegator
