Merge pull request #43 from github/AD-recursive

mtodd · mtodd · commit 1cdb257e9ae9 · 2014-09-01T20:03:04.000-07:00
Add group objectclass to allow AD nested group search.
diff --git a/github-ldap.gemspec b/github-ldap.gemspec
@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "github-ldap"
-  spec.version       = "1.3.4"
+  spec.version       = "1.3.5"
   spec.authors       = ["David Calavera"]
   spec.email         = ["david.calavera@gmail.com"]
   spec.description   = %q{Ldap authentication for humans}
diff --git a/lib/github/ldap/group.rb b/lib/github/ldap/group.rb
@@ -12,7 +12,7 @@ class Ldap
     class Group
       include Filter
 
-      GROUP_CLASS_NAMES = %w(groupOfNames groupOfUniqueNames posixGroup)
+      GROUP_CLASS_NAMES = %w(groupOfNames groupOfUniqueNames posixGroup group)
 
       attr_reader :ldap, :entry
 
diff --git a/test/group_test.rb b/test/group_test.rb
@@ -15,6 +15,10 @@ def setup
   end
 
   def test_group?
+    assert @group.group?(%w(group))
+    assert @group.group?(%w(groupOfUniqueNames))
+    assert @group.group?(%w(posixGroup))
+
     object_classes = %w(groupOfNames)
     assert @group.group?(object_classes)
     assert @group.group?(object_classes.map(&:downcase))
