Only iterate over Referall type entries in ReferralChaser

Dave Sims · Dave Sims · commit 0ac330a45911 · 2016-08-04T14:39:19.000-05:00
diff --git a/lib/github/ldap/referral_chaser.rb b/lib/github/ldap/referral_chaser.rb
@@ -44,8 +44,10 @@ def search(options)
         search_results = []
         referral_entries = []
 
-        search_results = connection.search(options) do |referral_entry|
-          referral_entries << referral_entry
+        search_results = connection.search(options) do |entry|
+          if entry[:search_referrals]
+            referral_entries << entry
+          end
         end
 
         unless referral_entries.empty?
diff --git a/test/referral_chaser_test.rb b/test/referral_chaser_test.rb
@@ -84,6 +84,13 @@ def test_returns_referral_search_results
     assert_equal(["result", "result"], results)
   end
 
+  def test_returns_referral_search_results
+    @mock_connection.expects(:search).yields({ foo: ["not a referral"] })
+
+    GitHub::Ldap::ReferralChaser::Referral.expects(:new).never
+    results = @chaser.search({})
+  end
+
   def test_referral_should_use_host_from_referral_string
     GitHub::Ldap::ConnectionCache.expects(:get_connection).with(has_entry(host: "dc4.ghe.local"))
     GitHub::Ldap::ReferralChaser::Referral.new("ldap://dc4.ghe.local/CN=Maggie%20Mae,CN=Users,DC=dc4,DC=ghe,DC=local", "", "")
