Support ignoring 404s when user is not found in GitHub instance #28
Conversation
jasonmacgowan
changed the title
|
I think that this is the only choice you have if you are sick and tired of these race conditions causing an entitlements deployment to fail.
Entitlements may not always be designed this way. At our recent offsite, we discussed changing Entitlements to naturally be an eventually consistent system. In which case, this problem you describe would be okay - Entitlements would naturally handle that. Entitlements isn't like that today. What will you do in the case where the user gets "stuck" - meaning that it continually does not get created? How would today's Entitlements system notice that since it has no knowledge of prior runs? It doesn't have the capacity to know "hey: I've tried adding this person like 6 times now, what gives?". How can we handle that scenario such that a human eventually gets notified? |
|
It's not perfect, but the "stuck" cases should be very rare. I'd expect the user to notice their access isn't working as expected and we'd have this fail condition well documented. |
|
Confirmed that the methods to remove organization membership and remove organization team membership do not raise |
jasonmacgowan
changed the title
This PR introduces a new configuration option,
ignore_not_found, which allows entitlements to ignoreHTTP 404errors when trying to perform organization and team membership operations on a GitHub instance where the user doesn't exist.Sometimes this option may be desirable when GitHub instance users are ultimately provisioned by other entitlements plugins and there is a race condition where this plugin may try to add a member before they exist.
For example, users may be provisioned in a GitHub instance via Enterprise Managed Users backed by an IdP which is also fed by entitlements. If the SCIM requests don't complete before this plugin is executed, the member will not exist in the instance and the run will fail. Since entitlements is designed to be run often, it may be acceptable to allow an "eventually consistent" state where entitlements would add the user the next time it runs once it's provisioned by the IdP.