Repo sync #39315
Merged
Repo sync #39315
+3,208
−846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joe Clark <31087804+jc-clark@users.noreply.github.com>
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions
bot
added
the
triage
There was a problem hiding this comment.
Pull Request Overview
This is an automated pull request to sync changes between the public and private repos. The PR contains multiple updates to API documentation data files, including updated descriptions, new fields, and configuration updates.
- Updates to GitHub Advanced Security descriptions across multiple API schema files
- Addition of new fields for organization membership and release immutability
- Updates to secret scanning patterns and search component improvements
Reviewed Changes
Copilot reviewed 60 out of 66 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/webhooks/lib/config.json | Updates SHA reference for webhook configuration |
| src/webhooks/data/ghes-*/schema.json | Adds descriptions for Advanced Security parameters and new membership/release fields |
| src/types.ts | Adds new properties to Permalink and Page types |
| src/secret-scanning/lib/config.json | Updates SHA references for secret scanning configuration |
| src/secret-scanning/data/public-docs.yml | Adds new Val Town API token pattern and enables push protection for WebDriver API key |
| src/search/components/input/*.tsx | React component updates for search functionality with key prop fixes |
| src/rest/lib/config.json | Updates SHA reference for REST API configuration |
| src/rest/data/ghes-*/schema.json | Adds Advanced Security descriptions and new API fields across multiple versions |
| @@ -42,15 +49,20 @@ export function SearchBarButton({ isSearchOpen, setIsSearchOpen, params, searchB | |||
| const placeHolderElements = t('search.input.placeholder') | |||
| .split(/({{[^}]+}})/) | |||
| .filter((item) => item.trim() !== '') | |||
| .map((item) => <>{item.trim()}</>) | |||
| placeHolderElements[1] = <CopilotIcon aria-hidden className="mr-1 ml-1" /> | |||
| .map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>) | |||
There was a problem hiding this comment.
[nitpick] Using array index as part of the React key can cause issues if the array order changes. Consider using a more stable identifier or just the trimmed content if it's unique.
Suggested change
| .map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>) | |
| .map((item) => <span key={item.trim()}>{item.trim()}</span>) |
Copilot uses AI. Check for mistakes.
Comment on lines
+52
to
+53
| .map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>) | ||
| placeHolderElements[1] = <CopilotIcon key="copilot-icon" aria-hidden className="mr-1 ml-1" /> |
There was a problem hiding this comment.
Direct array index assignment after mapping can be fragile. The assumption that index 1 exists and should be the icon might not hold if the placeholder text structure changes.
Suggested change
| .map((item, index) => <span key={`${item.trim()}-${index}`}>{item.trim()}</span>) | |
| placeHolderElements[1] = <CopilotIcon key="copilot-icon" aria-hidden className="mr-1 ml-1" /> | |
| .map((item, index) => | |
| item.trim() === '{{icon}}' | |
| ? <CopilotIcon key="copilot-icon" aria-hidden className="mr-1 ml-1" /> | |
| : <span key={`${item.trim()}-${index}`}>{item.trim()}</span> | |
| ) |
Copilot uses AI. Check for mistakes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to sync changes between the public and private repos.
Our bot will merge this pull request automatically.
To preserve continuity across repos, do not squash this pull request.