C++: Fix typeid IR translation #20060
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the IR translation for C++ typeid expressions by implementing proper IR instructions for both typeid with expressions and typeid with types. The changes address consistency issues in the IR generation where typeid operations were previously not properly handled.
Key changes:
- Adds new IR instruction types
TypeidExprandTypeidTypewith corresponding opcodes - Implements
TranslatedTypeidExprclass to handle the translation oftypeidoperations - Updates test expectations to reflect the corrected IR generation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/lib/semmle/code/cpp/ir/implementation/Opcode.qll | Adds TTypeidExpr and TTypeidType opcodes with their corresponding classes |
| cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/Instruction.qll | Defines TypeidExprInstruction and TypeidTypeInstruction classes |
| cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll | Implements TranslatedTypeidExpr class for handling typeid expression translation |
| Multiple .expected files | Updates test expectations to reflect the fixed IR translation |
cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
Outdated
Show resolved
Hide resolved
|
It looks likes this gives a slowdown on zeek/spicy. It looks like that project uses The other projects in DCA look fine. |
|
Makes sense. I think that's fine. I'm quite happy with the large reduction in Did you see that there's a large increase in |
Yes, drogon also has some uses of |
|
Yeah, I don't think this needs to be looked at in this PR since I highly doubt that this PR does anything incorrectly. |
|
Ok, merging. |
No description provided.