JS: model composed functions #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
xiemaisi
suggested changes
Aug 29, 2018
| fn = composed.getFunction(fnIndex) | | ||
| // flow out of the composed call | ||
| fnIndex = composed.getNumArgument() - 1 and | ||
| pred = fn.getFunction().getAReturnedExpr().flow() and |
| // flow through the composed functions | ||
| exists (DataFlow::FunctionNode predFn | | ||
| predFn = composed.getFunction(fnIndex - 1) | | ||
| pred = predFn.getFunction().getAReturnedExpr().flow() and |
|
Amended |
xiemaisi
approved these changes
Aug 30, 2018
|
Tests succeeded; merging. |
ghost
mentioned this pull request
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
…n-modifiers Add modifiers to array built-in functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a taint step for the arguments and return values of composed functions.
In anticipation of a potential merge with a "partial function" model, I have made the implementation private for now.
An evaluation with the security suite on big-apps.slugs flags nothing new, and it does not have a significant performance impact (internal link).