Timestamp improvements #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extracts and hardens the timestamp comparison logic by moving isTimestampOlder into its own module with stricter ISO-8601 UTC validation, and updates related safety-check code and tests.
- Extract
isTimestampOlderintosrc/functions/is-timestamp-older.jswith added format checks and exact ISO parsing - Update
commit-safety-checks.jsto import the new helper and remove its inline implementation - Add dedicated tests for the new helper and adjust existing
commit-safety-checkstests to mock and verify behavior
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/functions/is-timestamp-older.js | New module for timestamp comparison with strict format validation |
| src/functions/commit-safety-checks.js | Replaced inline isTimestampOlder with imported helper |
| tests/functions/is-timestamp-older.test.js | Comprehensive unit tests for isTimestampOlder, covering valid and invalid cases |
| tests/functions/commit-safety-checks.test.js | Adjusted tests to mock isTimestampOlder and removed direct debug assertions |
Comments suppressed due to low confidence (2)
tests/functions/is-timestamp-older.test.js:105
- Add an assertion to verify that
core.erroris called with the expected error message before throwing when parsing invalid dates (e.g., JS rollover corrections).
expect(() => isTimestampOlder('2024-02-30T12:00:00Z', '2024-10-15T11:00:00Z')).toThrow(/Invalid date format/)
tests/functions/commit-safety-checks.test.js:60
- [nitpick] Consider adding an assertion to verify that
isTimestampOlderis called with the correctcomment_created_atandcommit_created_atarguments, ensuring the comparison is invoked as expected.
isTimestampOlder.mockReturnValue(false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
isTimestampOlderfunction by extracting it into its own module (src/functions/is-timestamp-older.js) and introduces stricter validation for timestamp formats. Corresponding unit tests forisTimestampOlderhave been added, and existing tests incommit-safety-checkswere updated to mock the extracted function.