Skip to content

Committer metadata on confirmation comments #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2025

Conversation

GrantBirki
Copy link
Member

This pull request adds more metadata about the committer and if the commit is verified to the deployment confirmation message.

@Copilot Copilot AI review requested due to automatic review settings March 14, 2025 04:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds committer metadata and commit verification details to the deployment confirmation output.

  • Test cases updated to include additional fields: html_url/commit_html_url and committer.
  • Deployment confirmation message updated to display the committer and verification status.
  • Main deployment logic updated to retrieve and propagate the new metadata.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
tests/main.test.js Updated test data to include html_url and committer object for commit metadata.
tests/functions/deployment-confirmation.test.js Added new properties committer and commit_html_url in testing deployment confirmation data.
src/functions/deployment-confirmation.js Enhanced confirmation message to include new committer and commit_html_url details.
src/main.js Modified logic to retrieve commit metadata and pass it through to deployment confirmation.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@GrantBirki GrantBirki merged commit ae6decb into main Mar 14, 2025
4 checks passed
@GrantBirki GrantBirki deleted the deployment-confirmation-commit-metadata branch March 14, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant