Documentation: Update build.md's Vulkan section #14736
Merged
+18
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Vulkan backend build documentation.
github-actions
bot
added
the
documentation
|
@0cc4m Hey there, uh. I was away from my computer when you merged my PR. I had a minor grammar fix that I just committed to my fork right about now. Wondering if I should PR given that it is a minor change. Sorry, I should have probably committed it earlier! |
|
You can open another PR, sure. If you don't want it to be that small, there are some other issues with the Vulkan documentation that could be improved, like the example commands having unnecessary parameters like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
vulkan-sdkpackage and to align with LunarG's latest documentation.Purpose:
I made these changes primarily to reflect this notice put out by LunarG:
Additionally, I also rewrote, reorganized, and reformatted the Vulkan portion of build.md to hopefully make it less confusing as I was having confusion while reading it myself trying to build my own llama.cpp binaries.