DList (Difference List) #214
Conversation
| return new DList<>(kleisliTrampCompose(this.appendFn, other.appendFn)); | ||
| } | ||
|
|
||
| private static <A,B,C> F<A,Trampoline<C>> kleisliTrampCompose(F<B,Trampoline<C>> bc, F<A,Trampoline<B>> ab) { |
There was a problem hiding this comment.
Could this be useful as a public method of Trampoline?
There was a problem hiding this comment.
Its not really a true Kleisli composition, because of the use of Trampoline.suspend(...). But a bit of careful rearrangement compose could be added and used from Trampoline.
|
👍 probably need some javadoc though... |
|
Looks good. We should add the benchmarks to the code somewhere. Perhaps we need a new module for this (e.g. benchmarks). There have been various PRs related to performance that we should keep the evidence for. |
|
I agree with keeping the benchmarks somewhere. The first time I've seen DList on Hackage, I could not make sense of how it helped the performance. A separate module called benchmarks would be fine. I'm not experienced enough with Gradle to do it myself. |
|
I created #224 for the evidence of the DList. I will merge this PR now. |
Difference List is designed for efficient appending to the end of lists.
Edit:
Benchmark: http://pastebin.com/k2n8m9UN
Average over 10 runs...
List: 1422.8ms
Seq: 187.6ms
DList: 3.9ms
The benchmark is the average of 10 runs of appending 2000 lists each containing 100 elements.