Skip to content

Add type checking, refactor API for generator command line interface implementation #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Mar 1, 2023
Merged

Add type checking, refactor API for generator command line interface implementation #245

merged 38 commits into from
Mar 1, 2023

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Feb 28, 2023 •
edited
Loading

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #120
Resolves: #246

Description of the changes being introduced by the pull request:

@rszamszur
Refactor dev-dependencies, add and configure mypy
7cd0500
@rszamszur
Update poetry.lock
b076bb2
@rszamszur
Add mypy target
3a45793
@rszamszur
Add mypy check
be2c632
@rszamszur
Add py.typed marker file
f79892b
@rszamszur
Refactor poetry_path to shell utils module
17e792d
@rszamszur
Refactor ensure_permissions and ensure_project_data methods into fast…
2d0031d 
…api_mvc.utils.validators module
@rszamszur
Refactor constants into constants submodule, update tests
90ef38c
@rszamszur
Refactor insert_router_import method into controller generator
41eab70
@rszamszur
Drop Generator class, drop Copier wrappers, refactor codebase to use …
2a3e703 
…Copier directly, update tests
@rszamszur
Add type checking
1e9c232
@rszamszur
Update docstrings
3ba82bc
@rszamszur
Update Sphinx config, api.rst and generators.rst
a2e2114
@rszamszur
Update poetry.lock
8ab8df9
@rszamszur
Drop docs group
7865384
@rszamszur
Add mypy job
5823381
@rszamszur
Add mypy stage
613e67e
@rszamszur
Parametrize default Python for none-matrix jobs
289f15f
@rszamszur rszamszur added the refactor Related to major code refactoring/reorganisation label Feb 28, 2023
@rszamszur rszamszur self-assigned this Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023 •
edited
Loading

🚀 Deployed on https://63ff7383a1161828e2b96a6d--fastapi-mvc.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 21:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 22:21 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #245 (5da61ea) into master (4feab18) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        18    +3     
  Lines          418       437   +19     
=========================================
+ Hits           418       437   +19
Impacted Files Coverage Δ
fastapi_mvc/__init__.py 100.00% <ø> (ø)
fastapi_mvc/cli/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/base.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/cli.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/generate.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/new.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/run.py 100.00% <100.00%> (ø)
fastapi_mvc/cli/update.py 100.00% <100.00%> (ø)
fastapi_mvc/constants.py 100.00% <100.00%> (ø)
fastapi_mvc/generators/controller.py 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 22:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 22:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 1, 2023 08:45 Inactive
@rszamszur rszamszur changed the title Add type checking, refactor generators Add type checking, refactor API for generator command line interface implementation Mar 1, 2023
@rszamszur rszamszur marked this pull request as ready for review March 1, 2023 11:33
@github-actions github-actions bot temporarily deployed to pull request March 1, 2023 11:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 1, 2023 15:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 1, 2023 15:47 Inactive
@rszamszur rszamszur merged commit 7b6e52f into master Mar 1, 2023
@rszamszur rszamszur deleted the add_type_checking branch March 1, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rszamszur rszamszur

Labels
refactor Related to major code refactoring/reorganisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor API for generator command line interface implementation Implement type checking
2 participants
@rszamszur @codecov-commenter